Verbatim and strict query fixes

[gmarz]

• Add ability to set IsStrict and IsVerbatim on OIS query objects and at
  the query level for the fluent syntax. Setting at the container level
  for both APIs is a noop.
• Fix IsStrict check for initializer syntax. Previously, an exception was
  never thrown.

Closes #1898
Closes #1876

[russcam]

Should this also be

public bool IsWritable { get { return this.IsVerbatim || !IsConditionless(this); } }

i.e. negate IsConditionless?

[russcam]

IsStrict and IsVerbatim are now a noop on the outer container so the expectation in #1898 will not work.

I've added some tests for this.

Also fixed SpanQuery IsWritable

[russcam]

I would have expected this to pass i.e. IsVerbatim to cascade from the bool query to the contained clauses, but it would fail currently

public class BoolVerbatimQueryUsageTests : QueryDslUsageTestsBase
{
    protected override bool SupportsDeserialization => false;

    public BoolVerbatimQueryUsageTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cluster, usage) { }

    protected override object QueryJson => new
    {
        @bool = new
        {
            must = new object[]
            {
                new
                {
                    term = new
                    {
                        description = new
                        {
                            value = ""
                        }
                    }
                },
                new
                {
                    term = new
                    {
                        name = new
                        {
                            value = "foo"
                        }
                    }
                }
            }
        }
    };

    protected override QueryContainer QueryInitializer =>
        new BoolQuery
        {
            // cascade to clauses?
            IsVerbatim = true,
            Must = new List<QueryContainer>
                {
                    new TermQuery
                    {
                        Field = "description",
                        Value = ""
                    },
                    new TermQuery
                    {
                        Field = "name",
                        Value = "foo"
                    }
                }
        };


    protected override QueryContainer QueryFluent(QueryContainerDescriptor<Project> q) => q
        .Bool(b => b
            // cascade to clauses?
            .Verbatim()
            .Must(qt => qt
                .Term(t => t
                    .Field(p => p.Description)
                    .Value("")
                ), qt => qt
                .Term(t => t
                    .Field(p => p.Name)
                    .Value("foo")
                )
            )
        );
}

Is my thinking incorrect here?

[gmarz]

Nice catch 👍

[gmarz]

IsStrict and IsVerbatim are now a noop on the outer container so the expectation in #1898 will not work.

That's correct. IsVerbatim/Strict has to now be set at each desired query to obtain this behavior, which wasn't possible before.

I would have expected this to pass i.e. IsVerbatim to cascade from the bool query to the contained clauses, but it would fail currently

That would be ideal, but not sure if it's possible for the same reason we can't cascade from QueryContainer. I could be wrong though...

[russcam]

That would be ideal, but not sure if it's possible for the same reason we can't cascade from QueryContainer. I could be wrong though...

OK, apologies if we've discussed this before 😄 That does feel a little bit unintuitive for compound queries like bool where Verbatim() and Strict() are exposed still as they're inherited from QueryBase and QueryDescriptorBase<TDescriptor, TInterface>.

[Mpdreamz]

Rebased against 2.x appended some small touch ups, please review @gmarz

LGTM 👍