Feature/clean deps #3071
Merged
Feature/clean deps #3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Feb 4, 2018
There was a problem hiding this comment.
LGTM. Good to standardize on netstandard1.3 only 👍
Could I suggest Elasticsearch.Net.Connections.HttpWebRequestConnection for the name of the HttpWebRequest based connection? Would we also want a switch to test with this connection when running integration tests?
| @@ -10,15 +10,17 @@ static Program() | |||
| var currentDirectory = new DirectoryInfo(Directory.GetCurrentDirectory()); | |||
| if (currentDirectory.Name == "DocGenerator" && currentDirectory.Parent.Name == "CodeGeneration") | |||
| { | |||
| Console.WriteLine("IDE: " + currentDirectory); | |||
There was a problem hiding this comment.
Still needed? Or just used for debugging?
| InputDirPath = @"..\..\..\..\..\src"; | ||
| OutputDirPath = @"..\..\..\..\..\docs"; | ||
| BuildOutputPath = @"..\..\..\..\..\build\output"; | ||
| Console.WriteLine("CMD: " + currentDirectory); |
There was a problem hiding this comment.
Still needed? Or just used for debugging?
|
|
||
| namespace System.Collections.Generic | ||
| { | ||
|
|
||
| //TODO see if we can get rid of this |
Mpdreamz
force-pushed
the
feature/clean-deps
branch
from
f0d6409 to
d119205
Compare
|
A lot of changes went in today too:
|
Moved the desktop CLR connection into its own package. Removed all DOTNETCORE ifdefs
…orking on removing Elasticsearch.DotNetCoreOnly.sln
…tConnection randomly, TFM only kicks in on Windows
… -all and switch to -one to only test netcoreapp2.0
… without profiling support. This aids checking out -> open sln -> compile loop for everyone
… no xml exists in build/output
Mpdreamz
force-pushed
the
feature/clean-deps
branch
from
e5cdf54 to
d33269b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves master over to
netstandard1.3only for our class libs.Tests and other executables are now
netstandard2.0only.Removes all the
DOTNETCORErelated ifdef's.For now we keep the
WebRequestbasedHttpConnectionconnection around in a separate packageElasticsearch.Net.Connections.WebRequestConnection