Skip to content

Fix #3318 Support 3rd dimension (Z value) to points for geo_point and… #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2018

Conversation

Mpdreamz
Copy link
Member

… points in geo_shapes

@russcam russcam force-pushed the feature/ignore-z-value-6.3 branch from 4de6187 to 16e43e6 Compare August 20, 2018 01:18
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change to the default value for the attribute

@@ -36,5 +37,7 @@ public double DistanceErrorPercentage
public bool PointsOnly { get => Self.PointsOnly.GetValueOrDefault(false); set => Self.PointsOnly = value; }
/// <inheritdoc cref="IGeoShapeProperty.IgnoreMalformed"/>
public bool IgnoreMalformed { get => Self.IgnoreMalformed.GetValueOrDefault(false); set => Self.IgnoreMalformed = value; }
/// <inheritdoc cref="IGeoShapeProperty.IgnoreZValue"/>
public bool IgnoreZValue { get => Self.IgnoreZValue.GetValueOrDefault(false); set => Self.IgnoreZValue = value; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default should be true

@russcam russcam merged commit 0e86f0b into 6.3 Aug 20, 2018
@russcam russcam deleted the feature/ignore-z-value-6.3 branch August 24, 2018 06:47
Mpdreamz added a commit that referenced this pull request Sep 3, 2018
#3365)

This commit adds support for 3rd dimension (Z value) to points for geo_shapes

GeoShapeAttribute needs to implement IGeoShapeProperty
Mpdreamz added a commit that referenced this pull request Sep 3, 2018
#3365)

This commit adds support for 3rd dimension (Z value) to points for geo_shapes

GeoShapeAttribute needs to implement IGeoShapeProperty
Mpdreamz added a commit that referenced this pull request Sep 6, 2018
#3365)

This commit adds support for 3rd dimension (Z value) to points for geo_shapes

GeoShapeAttribute needs to implement IGeoShapeProperty

(cherry picked from commit 5cc9a51)
@Mpdreamz Mpdreamz mentioned this pull request Sep 10, 2018
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants