V65/processors #3528
Merged
V65/processors #3528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebrain
approved these changes
Jan 24, 2019
src/Nest/Ingest/Processor.cs
Outdated
| public interface IProcessor | ||
| { | ||
| // TODO: eventhough this property is ignored it has a JsonProperty because our GetCachedProperties helper prefers |
There was a problem hiding this comment.
TODO? (even though, needs a space)
src/Nest/Ingest/Processor.cs
Outdated
| /// <summary> | ||
| /// A tag is simply a string identifier of the specific instantiation of a certain processor | ||
| /// in a pipeline. The tag field does not affect the processor’s behavior, but is very useful | ||
| /// for bookkeeping and tracing errors to specific processors./ |
| /// <summary> | ||
| /// Similar to the Grok Processor, dissect also extracts structured fields out of a single text field | ||
| /// within a document. However unlike the Grok Processor, dissect does not use Regular Expressions. | ||
| /// This allows dissect’s syntax to be simple and for some cases faster than the Grok Processor. |
There was a problem hiding this comment.
This allows dissect’s syntax to be simple and, for some cases, faster than the Grok Processor.
| [JsonConverter(typeof(ProcessorJsonConverter<PipelineProcessor>))] | ||
| public interface IPipelineProcessor : IProcessor | ||
| { | ||
| //TODO this property clashes with the Name property on the IProcessor, need to rename base in master |
There was a problem hiding this comment.
We can't fix this in 6.x this needs to be changed in master updated the TODO to mention this. 👍
|
❤️ the nitpicks thanks @codebrain 👍 |
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2019
* Add support for the dissect ingest processor * Add support for if/tag and ignore_failure on all processors fixes #3506 * Add support for the drop processor * Add support for the set_security_user processor * Add support for the pipeline processor * addressed PR comments regarding xmldocs and TODO statements
Mpdreamz
added a commit
that referenced
this pull request
Jan 25, 2019
* Add support for the dissect ingest processor * Add support for if/tag and ignore_failure on all processors fixes #3506 * Add support for the drop processor * Add support for the set_security_user processor * Add support for the pipeline processor * addressed PR comments regarding xmldocs and TODO statements
Mpdreamz
added a commit
that referenced
this pull request
Jan 28, 2019
* Add support for the dissect ingest processor * Add support for if/tag and ignore_failure on all processors fixes #3506 * Add support for the drop processor * Add support for the set_security_user processor * Add support for the pipeline processor * addressed PR comments regarding xmldocs and TODO statements (cherry picked from commit 5e7e391)
Mpdreamz
added a commit
that referenced
this pull request
Mar 29, 2019
* Add support for the dissect ingest processor * Add support for if/tag and ignore_failure on all processors fixes #3506 * Add support for the drop processor * Add support for the set_security_user processor * Add support for the pipeline processor * addressed PR comments regarding xmldocs and TODO statements (cherry picked from commit 5e7e391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing properties and missing processors to NEST.
Add support for the dissect ingest processor
Add support for if/tag and ignore_failure on all processors fixes #3506
Add support for the drop processor
Add support for the set_security_user processor
Add support for the pipeline processor