Avoid doing multiple dictionary lookups #3580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Henr1k80 👍 |
SukharevAndrey
pushed a commit
to SukharevAndrey/elasticsearch-net
that referenced
this pull request
Mar 13, 2019
…terate bucket) (elastic#3580) (cherry picked from commit 750b4ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dictionary lookup involves get key hash, find bucket for hash and iterate bucket for key, so look the value up once, instead of checking if the key exists and then using the indexer to look up the value.
It also reduces the amount of duplicate hardcoded keys in the code.
Could not find any documentation for running the benchmark, so I haven't checked if it actually makes any difference. Haven't analyzed how often the code is executed.
Some places ContainsKey is used before Remove. That is not needed for Dictionary<>, as it will just return false for key not found, but I am uncertain of the specification for IDictionary<> void Remove, so I left it in place.