Skip to content

Fix/7.0 ga code generation #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 12, 2019
Merged

Fix/7.0 ga code generation #3664

merged 8 commits into from
Apr 12, 2019

Conversation

Mpdreamz
Copy link
Member

  • Moves our deprecated paths into dedicated *.patch.json while fix #35262 define deprecations of API's as a whole and urls elasticsearch#39063 is pending
  • moved all our *.patch.json files in a _Patched folder so that we can keep track of these easier.
  • Add XPack download again, I removed the folder classification previously so did not need @codebrain fix on 6.7 for the xpack downloads.
  • We now validate and automatically patch a part.required based on exposed urls. A warning is logged on the console if this happens so that we can fix the issue upstream.

Did a new code gen using 7.0 GA spec files, did not yield anything major, several new properties.

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small comment

@russcam russcam merged commit 45026fc into 7.x Apr 12, 2019
@russcam russcam deleted the fix/7.0-ga-code-generation branch April 12, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants