Added new TokenChars field to NGramTokenizers #375
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0.90.2 NGramTokenizer and EdgeNGramTokenizer support passing in character classes in the token_chars field.
|
Awesome, I love missing feature PR's @JoeDoyle23 👍 |
Mpdreamz
added a commit
that referenced
this pull request
Nov 4, 2013
Added new TokenChars field to NGramTokenizers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.90.2 NGramTokenizer and EdgeNGramTokenizer support passing in
character classes in the token_chars field as documented here: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/analysis-ngram-tokenizer.html
I didn't find any related tests for these classes so there are no tests with this PR. I did test this out on our live system running 0.90.3.