Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the setting to customize the serializer settings #382

Merged
merged 1 commit into from
Nov 13, 2013

Conversation

bytenik
Copy link
Contributor

@bytenik bytenik commented Nov 13, 2013

There's a setting exposed to customize the JSON serializer, by providing a delegate that takes the serializer settings and modifies it. However, the setting isn't used anywhere.

My project requires me to hook up some various changes to the serializer. Without this working properly, I'm forced to tap the private fields in NEST using reflection in order to customize the serializer, which is horribly hackish. Since this setting is exposed in NEST, I'm assuming it was intended to do something. :)

@Mpdreamz
Copy link
Member

It sure was, I had fixed this in my local branch already but hadn't gotten around to pushing it yet.

I will hopefully get some time today/tomorrow to do a new release.

Thanks @bytenik !

Mpdreamz added a commit that referenced this pull request Nov 13, 2013
Actually use the setting to customize the serializer settings
@Mpdreamz Mpdreamz merged commit 4fe760c into elastic:master Nov 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants