Skip to content

Feature/7.x/remove upgrade assistant #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Aug 7, 2019

This was a one off release.

We need to decide if we want this removed with 7.2 or 7.3 though.

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Aug 7, 2019

Test failures:

7.0.0

build.bat seed:9368 integrate 7.0.0 "writable" "rolloverindex,putpipeline"

Rolloverindex test fails due to a mapping problem with the random data on this seed that needs looking into.

PutPipeline failed due to cluster ProcessClusterEventTimeoutException which I've seen happen a couple of times before with this test.

7.0.0-SNAPSHOT

Failed   Tests.Indices.IndexManagement.SplitIndex.SplitIndexApiTests.ReturnsExpectedResponse
Error Message:
 Tests.Framework.EndpointTests.ResponseAssertionException : Expected response.ShardsAcknowledged to be true, but found False.
Response Under Test:
Valid NEST response built from a successful (200) low level call on PUT: /nest-fluentasync-77a092ae/_split/nest-fluentasync-77a092ae-target?pretty=true&error_trace=true
# Audit trail of this API call:
 - [1] HealthyResponse: Node: http://localhost:9200/ Took: 00:00:30.5230768
# Request:
{"settings":{"index.number_of_shards":8}}
# Response:
{
  "acknowledged" : true,
  "shards_acknowledged" : false,
  "index" : "nest-fluentasync-77a092ae-target"
}

shards_acknowledged: false is not common here, need to understand when acknowledged and shards_acknowledged differ and what this means.

Will create new tickets for these.

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Aug 9, 2019

Merging this in on my own accord @codebrain @russcam

@Mpdreamz Mpdreamz merged commit b031724 into 7.x Aug 9, 2019
@Mpdreamz Mpdreamz deleted the feature/7.x/remove-upgrade-assistant branch August 9, 2019 09:08
@Mpdreamz Mpdreamz added the Infra label Sep 24, 2019
@Mpdreamz
Copy link
Member Author

This is now also cherry picked to master

Mpdreamz added a commit that referenced this pull request Sep 24, 2019
* remove Nest.UpgradeAssistant

* remove Nest.7xUpgradeAssistant code

(cherry picked from commit b031724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant