Skip to content

Include in-progress snapshot for a policy with get SLM policy API #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2019
Merged

Include in-progress snapshot for a policy with get SLM policy API #4141

merged 2 commits into from
Oct 15, 2019

Conversation

Mpdreamz
Copy link
Member

addresses elastic/elasticsearch#45245

Note this only maps start_time_millis directly as DateTimeOffset in quite some places we map both XContent.timeField representations. Would be nice to clean this up in 8.0. Thoughts?

russcam
russcam suggested changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about naming

@russcam
Copy link
Contributor

russcam commented Oct 15, 2019

Note this only maps start_time_millis directly as DateTimeOffset in quite some places we map both XContent.timeField representations. Would be nice to clean this up in 8.0. Thoughts?

We can address these for 7.4.0 if we think it's good to. I was in two minds about mapping the _millis* properties to DateTimeOffset when implementing the SLM APIs. Thinking about it further, the millisecond/second since epoch properties for ML APIs are mapped to DateTimeOffset, so the SLM APIs should follow suit - it does make the Human property somewhat redundant in the client API.

@Mpdreamz Mpdreamz force-pushed the feature/7.x/slm-in-progress branch from b79402e to 6541584 Compare October 15, 2019 08:12
@Mpdreamz
Copy link
Member Author

Thinking about it further, the millisecond/second since epoch properties for ML APIs are mapped to DateTimeOffset, so the SLM APIs should follow suit

Agreed, no sense in exposing these twice. The human parameter has little meaning in the high level client as is.

@Mpdreamz Mpdreamz merged commit 91a3ba9 into 7.x Oct 15, 2019
@Mpdreamz Mpdreamz deleted the feature/7.x/slm-in-progress branch October 15, 2019 08:24
Mpdreamz added a commit that referenced this pull request Oct 15, 2019
@Mpdreamz
Include in-progress snapshot for a policy with get SLM policy API (#4141
f3377c5 
)

* Include in-progress snapshot for a policy with get SLM policy API

addresses elastic/elasticsearch#45245

* rename to LifecycleSnapshotnInProgress

(cherry picked from commit 91a3ba9)
@Mpdreamz
Copy link
Member Author

ported to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mpdreamz @russcam