Skip to content

Add support for WKT with GeoLocation type #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Nov 13, 2019

Relates: elastic/elasticsearch#44107

This commit adds support for Well Known Text (WKT) representations for GeoLocation, the type used
to represent geo_point in the client. Similar to WKT support in IGeoShape, an internal format field
is used to store whether an instance was deserialized from JSON or WKT, so that re-serialization
honours the original form deserialized from.

Relates: elastic/elasticsearch#44107

This commit adds support for Well Known Text (WKT) representations for GeoLocation, the type used
to represent geo_point in the client. Similar to WKT support in IGeoShape, an internal format field
is used to store whether an instance was deserialized from JSON or WKT, so that re-serialization
honours the original form deserialized from.
@codebrain codebrain mentioned this pull request Nov 13, 2019
39 tasks
@russcam russcam requested a review from codebrain November 13, 2019 23:46
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 3f3f98c into 7.x Nov 14, 2019
russcam added a commit that referenced this pull request Nov 14, 2019
Relates: elastic/elasticsearch#44107

This commit adds support for Well Known Text (WKT) representations for GeoLocation, the type used
to represent geo_point in the client. Similar to WKT support in IGeoShape, an internal format field
is used to store whether an instance was deserialized from JSON or WKT, so that re-serialization
honours the original form deserialized from.

(cherry picked from commit 3f3f98c)
russcam added a commit that referenced this pull request Nov 14, 2019
Relates: elastic/elasticsearch#44107

This commit adds support for Well Known Text (WKT) representations for GeoLocation, the type used
to represent geo_point in the client. Similar to WKT support in IGeoShape, an internal format field
is used to store whether an instance was deserialized from JSON or WKT, so that re-serialization
honours the original form deserialized from.

(cherry picked from commit 3f3f98c)
@russcam
Copy link
Contributor Author

russcam commented Nov 14, 2019

ported to 7.4 and master

@Mpdreamz Mpdreamz deleted the feature/geopoint-wkt branch February 10, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants