Integration tests: wait for green at startup

tests/Tests.Core/ManagedElasticsearch/Clusters/ClientTestClusterBase.cs

@@ -3,6 +3,7 @@
 using Elastic.Managed.Ephemeral.Plugins;
 using Elastic.Stack.Artifacts.Products;
 using Elastic.Xunit;
+using Elasticsearch.Net;
 using Nest;
 using Tests.Configuration;
 using Tests.Core.Client;
@@ -23,6 +24,15 @@ protected ClientTestClusterBase(ClientTestClusterConfiguration configuration) :
 		public IElasticClient Client => this.GetOrAddClient(s => ConnectionSettings(s.ApplyDomainSettings()));
 
 		protected virtual ConnectionSettings ConnectionSettings(ConnectionSettings s) => s;
+
+		protected sealed override void SeedCluster()
+		{
+			Client.Cluster.Health(new ClusterHealthRequest { WaitForStatus = WaitForStatus.Green });
+			SeedNode();
+			Client.Cluster.Health(new ClusterHealthRequest { WaitForStatus = WaitForStatus.Green });
+		}
+
+		protected virtual void SeedNode() { }
 	}
 
 	public class ClientTestClusterConfiguration : XunitClusterConfiguration

tests/Tests.Core/ManagedElasticsearch/Clusters/CrossCluster.cs

@@ -4,7 +4,7 @@ namespace Tests.Core.ManagedElasticsearch.Clusters
 {
 	public class CrossCluster : ClientTestClusterBase
 	{
-		protected override void SeedCluster()
+		protected override void SeedNode()
 		{
 			new DefaultSeeder(Client).SeedNode();
 

tests/Tests.Core/ManagedElasticsearch/Clusters/ReadOnlyCluster.cs

@@ -7,6 +7,6 @@ public class ReadOnlyCluster : ClientTestClusterBase
 	{
 		public ReadOnlyCluster() : base(MapperMurmur3) { }
 
-		protected override void SeedCluster() => new DefaultSeeder(Client).SeedNode();
+		protected override void SeedNode() => new DefaultSeeder(Client).SeedNode();
 	}
 }

tests/Tests.Core/ManagedElasticsearch/Clusters/TimeSeriesCluster.cs

@@ -8,8 +8,7 @@ namespace Tests.Core.ManagedElasticsearch.Clusters
 {
 	public class TimeSeriesCluster : XPackCluster
 	{
-		protected override void SeedCluster() =>
-			new TimeSeriesSeeder(Client).SeedNode();
+		protected override void SeedNode() => new TimeSeriesSeeder(Client).SeedNode();
 	}
 
 	public class TimeSeriesSeeder

tests/Tests.Core/ManagedElasticsearch/Clusters/UnbalancedCluster.cs

@@ -6,7 +6,7 @@ namespace Tests.Core.ManagedElasticsearch.Clusters
 	//TODO does this need a whole separate cluster?
 	public class UnbalancedCluster : ClientTestClusterBase
 	{
-		protected override void SeedCluster() =>
+		protected override void SeedNode() =>
 			new DefaultSeeder(Client, new IndexSettings { NumberOfShards = 3, NumberOfReplicas = 2 })
 				.SeedNode();
 	}

tests/Tests.Core/ManagedElasticsearch/Clusters/WritableCluster.cs

@@ -39,7 +39,7 @@ private static ClientTestClusterConfiguration CreateConfiguration()
 			};
 		}
 
-		protected override void SeedCluster()
+		protected override void SeedNode()
 		{
 			var seeder = new DefaultSeeder(Client);
 			seeder.SeedNode();

tests/Tests.Core/ManagedElasticsearch/Clusters/XPackCluster.cs

@@ -27,7 +27,7 @@ public XPackClusterConfiguration(ClusterFeatures features) : base(ClusterFeature
 			TrialMode = XPackTrialMode.Trial;
 			AdditionalBeforeNodeStartedTasks.Add(new EnsureWatcherActionConfigurationInElasticsearchYaml());
 			AdditionalBeforeNodeStartedTasks.Add(new EnsureWatcherActionConfigurationSecretsInKeystore());
-			AdditionalBeforeNodeStartedTasks.Add(new EnsureNativeSecurityRealmEnabledInElasticsearchYaml());		
+			AdditionalBeforeNodeStartedTasks.Add(new EnsureNativeSecurityRealmEnabledInElasticsearchYaml());
 			ShowElasticsearchOutputAfterStarted = true; //this.TestConfiguration.ShowElasticsearchOutputAfterStarted;
 		}
 	}
@@ -46,6 +46,13 @@ protected virtual ConnectionSettings Authenticate(ConnectionSettings s) => s
 		protected virtual ConnectionSettings ConnectionSettings(ConnectionSettings s) => s
 			.ServerCertificateValidationCallback(CertificateValidations.AllowAll);
 
-		protected override void SeedCluster() => new DefaultSeeder(Client).SeedNode();
+		protected sealed override void SeedCluster()
+		{
+			Client.Cluster.Health(new ClusterHealthRequest { WaitForStatus = WaitForStatus.Green });
+			SeedNode();
+			Client.Cluster.Health(new ClusterHealthRequest { WaitForStatus = WaitForStatus.Green });
+		}
+
+		protected virtual void SeedNode() => new DefaultSeeder(Client).SeedNode();
 	}
 }

tests/Tests/ClientConcepts/Certificates/SslAndKpiXPackCluster.cs

@@ -15,6 +15,6 @@ public SslAndKpiXPackCluster() : this(new SslAndKpiClusterConfiguration()) { }
 
 		public SslAndKpiXPackCluster(SslAndKpiClusterConfiguration configuration) : base(configuration) { }
 
-		protected override void SeedCluster() { }
+		protected override void SeedNode() { }
 	}
 }

tests/Tests/Document/Multiple/Reindex/ReindexApiTests.cs

@@ -14,12 +14,12 @@ namespace Tests.Document.Multiple.Reindex
 {
 	public class ReindexCluster : ClientTestClusterBase
 	{
-		protected override void SeedCluster() => new DefaultSeeder(Client).SeedNodeNoData();
+		protected override void SeedNode() => new DefaultSeeder(Client).SeedNodeNoData();
 	}
 
 	public class ManualReindexCluster : ClientTestClusterBase
 	{
-		protected override void SeedCluster() => new DefaultSeeder(Client).SeedNodeNoData();
+		protected override void SeedNode() => new DefaultSeeder(Client).SeedNodeNoData();
 	}
 
 	public class ReindexApiTests : IClusterFixture<ManualReindexCluster>

tests/Tests/QueryDsl/BoolDsl/BoolApiTests.cs

@@ -28,7 +28,7 @@ public enum E
 			Option2
 		}
 
-		protected override void SeedCluster()
+		protected override void SeedNode()
 		{
 			var client = Client;
 			var index = client.Indices.Create(Index<A>(), i => i

tests/Tests/XPack/MachineLearning/MachineLearningCluster.cs

@@ -28,7 +28,7 @@ public MachineLearningCluster() : base(new XPackClusterConfiguration
 			Timeout = TimeSpan.FromMinutes(10),
 		}) { }
 
-		protected override void SeedCluster() => new MachineLearningSeeder(Client, ClusterConfiguration.FileSystem).SeedNode();
+		protected override void SeedNode() => new MachineLearningSeeder(Client, ClusterConfiguration.FileSystem).SeedNode();
 	}
 
 	public class DownloadMachineLearningSampleDataDistribution : ClusterComposeTask