Move intrusive xpack tests to own cluster #4446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enrich is now a CoordinatedUsageTest Slm is in its own cluster Security is in its own cluster to not have role/users API potentially cluttering the rest of the tests
…ud covers this already
russcam
approved these changes
Feb 24, 2020
russcam
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Small changes, make sure we print errors at the end when running test suite locally. * include branches ending in .x * Move intrusive xpack tests to own cluster (#4446) * Moves tests further into their own clusters * Enrich is now a CoordinatedUsageTest * Slm is in its own cluster * Security is in its own cluster to not have role/users API potentially cluttering the rest of the tests * GetRepository does not need to be an integration test as RepositoryCrud covers this already * Move watcher tests to own cluster * fix failing unit test after moving enrich stats api over to unit test only * update docs
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Small changes, make sure we print errors at the end when running test suite locally. * include branches ending in .x * Move intrusive xpack tests to own cluster (#4446) * Moves tests further into their own clusters * Enrich is now a CoordinatedUsageTest * Slm is in its own cluster * Security is in its own cluster to not have role/users API potentially cluttering the rest of the tests * GetRepository does not need to be an integration test as RepositoryCrud covers this already * Move watcher tests to own cluster * fix failing unit test after moving enrich stats api over to unit test only * update docs
github-actions bot
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Small changes, make sure we print errors at the end when running test suite locally. * include branches ending in .x * Move intrusive xpack tests to own cluster (#4446) * Moves tests further into their own clusters * Enrich is now a CoordinatedUsageTest * Slm is in its own cluster * Security is in its own cluster to not have role/users API potentially cluttering the rest of the tests * GetRepository does not need to be an integration test as RepositoryCrud covers this already * Move watcher tests to own cluster * fix failing unit test after moving enrich stats api over to unit test only * update docs
russcam
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Small changes, make sure we print errors at the end when running test suite locally. * include branches ending in .x * Move intrusive xpack tests to own cluster (#4446) * Moves tests further into their own clusters * Enrich is now a CoordinatedUsageTest * Slm is in its own cluster * Security is in its own cluster to not have role/users API potentially cluttering the rest of the tests * GetRepository does not need to be an integration test as RepositoryCrud covers this already * Move watcher tests to own cluster * fix failing unit test after moving enrich stats api over to unit test only * update docs Co-authored-by: Martijn Laarman <[email protected]>
russcam
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Small changes, make sure we print errors at the end when running test suite locally. * include branches ending in .x * Move intrusive xpack tests to own cluster (#4446) * Moves tests further into their own clusters * Enrich is now a CoordinatedUsageTest * Slm is in its own cluster * Security is in its own cluster to not have role/users API potentially cluttering the rest of the tests * GetRepository does not need to be an integration test as RepositoryCrud covers this already * Move watcher tests to own cluster * fix failing unit test after moving enrich stats api over to unit test only * update docs Co-authored-by: Martijn Laarman <[email protected]>
russcam
reviewed
Feb 25, 2020
| { | ||
| public static class ClientExtensions | ||
| { | ||
| public static ClusterHealthResponse WaitForSecurityIndices(this IElasticClient client) => |
There was a problem hiding this comment.
This doesn't look like it's called?
russcam
reviewed
Feb 25, 2020
| @@ -14,46 +9,20 @@ namespace Tests.XPack.Enrich.DeletePolicy | |||
| { | |||
| [SkipVersion("<7.5.0", "Introduced in 7.5.0")] | |||
| public class DeletePolicyApiTests | |||
| : ApiIntegrationTestBase<XPackCluster, DeleteEnrichPolicyResponse, IDeleteEnrichPolicyRequest, DeleteEnrichPolicyDescriptor, DeleteEnrichPolicyRequest> | |||
| : ApiTestBase<EnrichCluster, DeleteEnrichPolicyResponse, IDeleteEnrichPolicyRequest, DeleteEnrichPolicyDescriptor, DeleteEnrichPolicyRequest> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.