Skip to content

Update System.Diagnostics.DiagnosticSource #5140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

stevejgordon
Copy link
Contributor

Update to use the latest 5.0.0 version which supports all targets.

Update to use the latest 5.0.0 version which supports all targets.
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a note on the Dispose on Diagnostic

@stevejgordon stevejgordon requested a review from Mpdreamz December 1, 2020 12:30
@stevejgordon
Copy link
Contributor Author

@Mpdreamz Requesting a re-review after updating to implement IDisposable.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! mind opening a ticket/pr on elastic/elastic-transport-net straight after merging?

@stevejgordon stevejgordon merged commit c311a40 into 7.10 Dec 4, 2020
@stevejgordon stevejgordon deleted the infra/diagnostic-source branch December 4, 2020 09:42
github-actions bot pushed a commit that referenced this pull request Dec 4, 2020
* Update System.Diagnostics.DiagnosticSource - Update to use the latest 5.0.0 version which supports all targets.
* Implement IDisposable
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2020

The backport to master failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5140-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 c311a400a9b87c0ea2b6397809eb73780e0077ce
# Push it to GitHub
git push --set-upstream origin backport-5140-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master

Then, create a pull request where the base branch is master and the compare/head branch is backport-5140-to-master.

stevejgordon added a commit that referenced this pull request Dec 4, 2020
* Update System.Diagnostics.DiagnosticSource - Update to use the
latest 5.0.0 version which supports all targets.
* Implement IDisposable
* Includes fixes to point in time tests due to different transport
namespace.
stevejgordon added a commit that referenced this pull request Dec 4, 2020
* Update System.Diagnostics.DiagnosticSource - Update to use the latest 5.0.0 version which supports all targets.
* Implement IDisposable

Co-authored-by: Steve Gordon <[email protected]>
stevejgordon added a commit that referenced this pull request Dec 7, 2020
* Update System.Diagnostics.DiagnosticSource - Update to use the
latest 5.0.0 version which supports all targets.
* Implement IDisposable
* Includes fixes to point in time tests due to different transport
namespace.
@ejsmith
Copy link
Contributor

ejsmith commented Dec 7, 2020

@stevejgordon any plans to support ActivitySource ?

@stevejgordon
Copy link
Contributor Author

@ejsmith It's something I've recently added to my list to investigate and review. We're certainly keen to leverage newer features where they provide value. Beyond the activities built into HttpClient etc. do you have specific types of activities which you'd find useful to track on top, within the client? Would love to drive the planning from developer focused requirements.

@ejsmith
Copy link
Contributor

ejsmith commented Dec 7, 2020

@stevejgordon would just be interested in the same things that the DiagnosticSources currently output. Just in the more modern and easier to subscribe to ActivitySource format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants