-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update System.Diagnostics.DiagnosticSource #5140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update to use the latest 5.0.0 version which supports all targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a note on the Dispose
on Diagnostic
@Mpdreamz Requesting a re-review after updating to implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! mind opening a ticket/pr on elastic/elastic-transport-net straight after merging?
* Update System.Diagnostics.DiagnosticSource - Update to use the latest 5.0.0 version which supports all targets. * Implement IDisposable
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5140-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 c311a400a9b87c0ea2b6397809eb73780e0077ce
# Push it to GitHub
git push --set-upstream origin backport-5140-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master Then, create a pull request where the |
* Update System.Diagnostics.DiagnosticSource - Update to use the latest 5.0.0 version which supports all targets. * Implement IDisposable * Includes fixes to point in time tests due to different transport namespace.
* Update System.Diagnostics.DiagnosticSource - Update to use the latest 5.0.0 version which supports all targets. * Implement IDisposable Co-authored-by: Steve Gordon <[email protected]>
@stevejgordon any plans to support |
@ejsmith It's something I've recently added to my list to investigate and review. We're certainly keen to leverage newer features where they provide value. Beyond the activities built into |
@stevejgordon would just be interested in the same things that the |
Update to use the latest 5.0.0 version which supports all targets.