Skip to content

[Backport master] Add geo-line aggregration #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

stevejgordon
Copy link
Contributor

Backport 3312afe from #5286

@Mpdreamz This re-enables some previously skipped tests (on master). I've run integration locally and all seems fine. Happy for these to be enabled as per the 7.x branch?

* Add geo-line aggregation and initial test
* Make AggregationUsageTestBase generic
* Add documentation

(cherry picked from commit 3312afe)
@stevejgordon stevejgordon requested a review from Mpdreamz January 30, 2021 10:39
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This re-enables some previously skipped tests (on master). I've run integration locally and all seems fine. Happy for these to be enabled as per the 7.x branch?

100%, The presence of SkipVersion on master should probably be a compiler warning even.

@stevejgordon
Copy link
Contributor Author

@Mpdreamz I may have been over keen. Some of these do fail against latest. Just scrolled back from my local commands I'd ran latest-7 so will fix that up and push a new commit. I'll probably skip for now and add an issue to track what appears to be aggregation naming changes.

These will be removed and trackked in #5301
@stevejgordon stevejgordon merged commit acad200 into master Feb 2, 2021
@stevejgordon stevejgordon deleted the backport-5286-to-master branch February 2, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants