Skip to content

[Backport 8.14] Improve ToCamelCase to match STJ behavior #8280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
// See the LICENSE file in the project root for more information.

using System;

#if ELASTICSEARCH_SERVERLESS
namespace Elastic.Clients.Elasticsearch.Serverless;
#else
Expand All @@ -10,18 +12,53 @@ namespace Elastic.Clients.Elasticsearch;

internal static class StringExtensions
{
internal static string ToCamelCase(this string s)
// Taken from:
// https://github.com/dotnet/runtime/blob/main/src/libraries/System.Text.Json/Common/JsonCamelCaseNamingPolicy.cs

internal static string ToCamelCase(this string name)
{
if (string.IsNullOrEmpty(s))
return s;
if (string.IsNullOrEmpty(name) || !char.IsUpper(name[0]))
{
return name;
}

#if NET
return string.Create(name.Length, name, (chars, name) =>
{
name.CopyTo(chars);
FixCasing(chars);
});
#else
var chars = name.ToCharArray();
FixCasing(chars);
return new string(chars);
#endif
}

private static void FixCasing(Span<char> chars)
{
for (var i = 0; i < chars.Length; i++)
{
if (i == 1 && !char.IsUpper(chars[i]))
{
break;
}

var hasNext = (i + 1 < chars.Length);

if (!char.IsUpper(s[0]))
return s;
// Stop when next char is already lowercase.
if (i > 0 && hasNext && !char.IsUpper(chars[i + 1]))
{
// If the next char is a space, lowercase current char before exiting.
if (chars[i + 1] == ' ')
{
chars[i] = char.ToLowerInvariant(chars[i]);
}

var camelCase = char.ToLowerInvariant(s[0]).ToString();
if (s.Length > 1)
camelCase += s.Substring(1);
break;
}

return camelCase;
chars[i] = char.ToLowerInvariant(chars[i]);
}
}
}
Loading