Skip to content

Ignore obsolete warning in tests #8290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

svalbuena
Copy link
Contributor

@svalbuena svalbuena commented Aug 8, 2024

Added a rule in .editorconfig to ignore any obsolete method usage warning, rather than adding the pragma on every impacted class, this fixes some cases that were missing the pragma statement.
The tests still don't build nor work, but it's a step towards that.

@svalbuena svalbuena changed the title ignore obsolete warning in tests Ignore obsolete warning in tests Aug 8, 2024
@flobernd
Copy link
Member

flobernd commented Aug 9, 2024

Thank you for the PR. I think adding this directive to .editorconfig is okay for now. A lot of tests have not been adjusted after the breaking 8.13 release yet. This is definitely something I would like to fix in a timely manner.

@flobernd flobernd merged commit 0c3a7e7 into elastic:main Aug 9, 2024
7 of 22 checks passed
flobernd pushed a commit that referenced this pull request Aug 9, 2024
flobernd pushed a commit that referenced this pull request Aug 9, 2024
flobernd pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Relates to a 8.x client version Area: Tests Category: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants