-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add more examples to the documentation #8374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @flobernd !
Small edits for Elastic docs style for headings.
One thought: would it make sense to have an examples
subfolder under usage
to collect the 4 pages? Not sure...
Am also going to add a commit to add the pages to the nav
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Co-authored-by: Marci W <[email protected]>
Thanks for the review and the suggestions @marciw 🙂
Could definitely make sense - especially when we add even more examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow we ended up with a couple of duplicate headings -- going to accept these suggestions to fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you again @marciw! Seems I somehow messed up the rebase which caused the headers to get duplicated. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-serverless serverless
# Navigate to the new working tree
cd .worktrees/backport-serverless
# Create a new branch
git switch --create backport-8374-to-serverless
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 5cde9691b5a4613068ae1c97e8c6268575f77d57
# Push it to GitHub
git push --set-upstream origin backport-8374-to-serverless
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-serverless Then, create a pull request where the |
Adds copy/paste-able examples for very common use-cases.