re #880 - Ensures that a nested filter consisting of only a filter does ... #881
Conversation
…lter does not result in a conditionless NEST filter (leading to its exclusion from generated json query)
|
LGTM. Great catch @Philo ! Thanks for reporting and submitting a fix. Just need you to sign the CLA so we can pull it in, if you don't mind. Also, for future pull requests, we recommend installing the EditorConfig Visual Studio extension for auto formatting to match our style guidelines. |
|
Hey @Philo, just following up to see if you've had the chance to sign the CLA yet? Would really like to merge this in. |
|
Yes, i've completed the CLA. Do i need to pass anything back to you from it? |
|
Nope, nothing more to do on your part. There's sometimes a delay between signing the CLA and the confirmation on our end. Once I can confirm I'll pull this in. Thanks again. |
|
@Philo, can you try signing the CLA one more time? Sorry, but for some reason the confirmation never came through. |
|
@gmarz, ive completed the CLA, perhaps i didn't verify it correctly, hopefully will be fine now |
|
@Philo, it just came in. Sorry for the delay! |
re #880 - Ensures that a nested filter consisting of only a filter does ...
...not result in a conditionless NEST filter (leading to its exclusion from generated json query)