Remove class/interface validation when retrieving type from ElasticType #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #731, this was causing an ArgumentException to be thrown when mapping generic objects with value type parameters (List<int>, Dictionary<long, string>, etc..). The check doesn't seem necessary since ElasticTypeAttribute is already constained to classes at compile time. Also cleaned up PropertyNameResolver a bit. Closes #926
Mpdreamz
added a commit
that referenced
this pull request
Sep 8, 2014
Remove class/interface validation when retrieving type from ElasticType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #731, this was causing an ArgumentException to be thrown when
mapping generic objects with value type parameters (List,
Dictionary<long, string>, etc..). The check doesn't seem necessary since
ElasticTypeAttribute is already constained to classes at compile time.
Also cleaned up PropertyNameResolver a bit.
Closes #926