Prep for 6.8 release #178
Merged
Prep for 6.8 release #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f35efcb#diff-87ca88ecdb2370e98cca19dade0beee4 looks like you left over some debugging stuff. The commit includes a tidy of many files which hides the actual logic changes. Tidy is nice and every publich source should be tidy, but don't try to backdoor-introduce it to a project. |
|
@sewi-cpan thanks for reporting. I'm still working on this PR and I'll remove the data dump and other includes. |
Sorry, didn't recognize that you're maintainer :) |
|
@sewi-cpan don't worry. I'm glad that I have some code review. Thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the API endpoints update for
Elasticsearch 6.8.7. Moreover, it includes the unit test and YAML test for OSS and XPack.This PR fixes also #179 exposing an
xpackobject. The XPack endpoints have been moved into the Direct client, there's no need anymore to specify XPack as plugin.