Skip to content

Added parameters for ES 6.6 + updated cpliakas/git-wrapper version #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Added parameters for ES 6.6 + updated cpliakas/git-wrapper version #882

merged 1 commit into from
Apr 25, 2019

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Apr 24, 2019

This PR fixes the integration tests for ES 6.6.0 + update cpliakas/git-wrapper library version in composer to manage PHP 7.0 and PHP 7.1+.

The ES 6.6.0 release introduced some API parameters addition and deprecation, as follows:

  • added the rest_total_hits_as_int parameter, source here;
  • added if_seq_no, if_primary_term parameters to index, source here;
  • deprecated _source_exclude and _source_include parameters in favor of _source_excludes and _source_include, source here.

Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezimuel
Copy link
Contributor Author

ezimuel commented Apr 25, 2019

Thanks @philkra.

@ezimuel ezimuel merged commit 5dccf63 into elastic:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants