Skip to content

Allow retries for statuses other than 429 in streaming bulk #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

ayayron
Copy link
Contributor

@ayayron ayayron commented Sep 22, 2022

Closes #1004.

This updates #1005 to work for both the async and sync client as well as adding tests.

Closes elastic#1004.

This updates elastic#1005 to
work for both the async and sync client as well as adding tests.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@pquentin
Copy link
Member

buildkite test this please

Copy link
Contributor

@miguelgrinberg miguelgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some comments seemed inaccurate to me so I've added some suggested improvements.

@pquentin
Copy link
Member

buildkite test this please

@pquentin pquentin changed the title Allow retries for statuses other than 429 in bulk streaming Allow retries for statuses other than 429 in streaming bulk Nov 12, 2024
@pquentin pquentin merged commit 51aacce into elastic:main Nov 12, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Co-authored-by: Miguel Grinberg <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 51aacce)
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
Co-authored-by: Miguel Grinberg <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 51aacce)
@pquentin
Copy link
Member

Thank you for your contribution, it is now released as part of 8.16.0: https://github.com/elastic/elasticsearch-py/releases/tag/v8.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow retries for statuses other than 429 in streaming_bulk
4 participants