-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add back inference.inference API #2873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This function was removed from the specification in favor of one API per provider and task type, but the existing function was stable and widely used in Python. Still, we mark it as deprecated to encourage users to migrate to the new APIs.
t.Union[ | ||
str, | ||
t.Literal[ | ||
"chat_completion", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably okay, but just noting that chat_completion
is not in the list of task types in the current (8.17) client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I wondered about it. Not including it encourages using the new way (post_eis_chat_completion
, I guess) but having it allows users to keep using it for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to keep it if it is a legal value. I only pointed it out in case it was a mistake.
* Add back inference.inference API This function was removed from the specification in favor of one API per provider and task type, but the existing function was stable and widely used in Python. Still, we mark it as deprecated to encourage users to migrate to the new APIs. * Fix lint (cherry picked from commit eac539d)
* Add back inference.inference API This function was removed from the specification in favor of one API per provider and task type, but the existing function was stable and widely used in Python. Still, we mark it as deprecated to encourage users to migrate to the new APIs. * Fix lint (cherry picked from commit eac539d)
* Add back inference.inference API This function was removed from the specification in favor of one API per provider and task type, but the existing function was stable and widely used in Python. Still, we mark it as deprecated to encourage users to migrate to the new APIs. * Fix lint (cherry picked from commit eac539d)
* Add back inference.inference API This function was removed from the specification in favor of one API per provider and task type, but the existing function was stable and widely used in Python. Still, we mark it as deprecated to encourage users to migrate to the new APIs. * Fix lint (cherry picked from commit eac539d) Co-authored-by: Quentin Pradet <[email protected]>
* Add back inference.inference API This function was removed from the specification in favor of one API per provider and task type, but the existing function was stable and widely used in Python. Still, we mark it as deprecated to encourage users to migrate to the new APIs. * Fix lint (cherry picked from commit eac539d) Co-authored-by: Quentin Pradet <[email protected]>
* Add back inference.inference API This function was removed from the specification in favor of one API per provider and task type, but the existing function was stable and widely used in Python. Still, we mark it as deprecated to encourage users to migrate to the new APIs. * Fix lint (cherry picked from commit eac539d) Co-authored-by: Quentin Pradet <[email protected]>
This reverts commit eac539d. This API will be added back through the specification and isn't deprecated anymore.
This function was removed from the specification in favor of one API per provider and task type, but the existing function was stable and widely used in Python. Still, we mark it as deprecated to encourage users to migrate to the new APIs. Usage: