use internal aggregation range class for date aggregation ranges #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
(cherry picked from commit 0d23e6b)
miguelgrinberg
added a commit
that referenced
this pull request
Apr 10, 2025
…) (#2898) (cherry picked from commit 0d23e6b) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After elastic/elasticsearch-specification#4243 I realized that the DSL code generator wasn't properly assigning the type to date aggregation range attributes.
Note that the changes in this diff aside from the change in
dsl-generator.pyare unrelated. These are just minor changes in the spec that are unrelated to this PR.