Skip to content

Remove "patron" hint from the AWS guide #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

julik
Copy link
Contributor

@julik julik commented Feb 21, 2016

because using Patron is not a prerequisite when using this workflow, and might in fact mislead
the user to installing Patron and adding it to his/her Gemfile just because this is mentioned in the documentation.

because using Patron is not a prerequisite when
using this workflow, and might in fact mislead
the user to installing Patron and adding it
to his Gemfile just because this is mentioned
in the documentation
@karmi
Copy link
Contributor

karmi commented Mar 4, 2016

Yes, correct, nice catch. May I ask you to sign the CLA so I can merge the contribution, please? (I know it looks silly to require CLA for a one line change in README, but it's the easiest and fastest way for us to process contributions...)

@karmi karmi added the waiting label Mar 4, 2016
@julik
Copy link
Contributor Author

julik commented Mar 4, 2016

I did sign the CLA, but I never got the confirmation email about it (me at julik dot nl). I can also bike by your office and sign it in person, but only if you give me a cup of espresso in exchange ❤️

@karmi
Copy link
Contributor

karmi commented Mar 10, 2016

I did sign the CLA, but I never got the confirmation email about it

Hi Julik, that is weird! Would be so kind and tried again? Maybe there's some kind of problem we need to debug -- I don't see you in our records indeed.

I can also bike by your office and sign it in person, but only if you give me a cup of espresso in exchange

I'm about 900km from there, but I can arrange a cup of espresso -- not terribly great, warn you :) I'm afraid, though, that we still need the signature in the systems, so the whole toolchain knows about you :)

@julik
Copy link
Contributor Author

julik commented Mar 14, 2016

I have resubmitted the CLA

@karmi karmi closed this in e4588ec Mar 14, 2016
@karmi
Copy link
Contributor

karmi commented Mar 14, 2016

Perfect, thanks!, tweaked the commit message a little bit and merged.

rafayqayyum pushed a commit to rafayqayyum/elasticsearch-ruby that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants