Skip to content

Add missing aggregator. Fixes #286 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add missing aggregator. Fixes #286 #287

wants to merge 3 commits into from

Conversation

tmaier
Copy link
Contributor

@tmaier tmaier commented Mar 13, 2016

@karmi
Copy link
Contributor

karmi commented Mar 13, 2016

Hi Tobias, great!, can you please add a simple unit test for the method? See test/unit/aggregations -- really a simple test which tests the basic behaviour, see eg. range_test.rb

@karmi karmi added the waiting label Mar 13, 2016
@tmaier
Copy link
Contributor Author

tmaier commented Mar 13, 2016

Hi Karel,

I added the unit test. I found that the terms_test.rb is a better example for this easy aggregator.

Best,

Tobias

karmi pushed a commit that referenced this pull request Mar 14, 2016
@tmaier @karmi
[DSL] Added the missing aggregation
821576d 
See: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-missing-aggregation.html

Related: #286, #287
@karmi karmi closed this in 3271d03 Mar 14, 2016
@karmi
Copy link
Contributor

karmi commented Mar 14, 2016

Hi, I've squashed the commits, and added a fixed some mishaps (wrong naming, description, etc) in another commit, and merged. Thanks!

@tmaier tmaier deleted the tmaier-patch-1 branch June 30, 2021 12:42
picandocodigo pushed a commit that referenced this pull request Jan 10, 2022
@tmaier @karmi
[DSL] Added the missing aggregation
b36677e 
See: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-missing-aggregation.html

Related: #286, #287
picandocodigo pushed a commit that referenced this pull request Jan 10, 2022
@karmi
[DSL] Fixed the documentation and naming for the missing aggregatio…
f6b1a1c 
…n in 821576d

Closes #286
Closes #287
rafayqayyum pushed a commit to rafayqayyum/elasticsearch-ruby that referenced this pull request Mar 4, 2025
@ebouchut @karmi
[STORE] Added shortcut links to both main chapters on patterns in the…
2b0999b 
… README

Closes elastic#287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmaier @karmi