Skip to content

Correct name of option for number of nodes #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zamith
Copy link
Contributor

@zamith zamith commented Nov 11, 2016

Why:

  • Both the readme and the class level docs refer to what I assume is the
    old name of the option to configure the number of nodes in the test
    cluster

This change addresses the need by:

  • Changing the documentation to the new names

Why:

* Both the readme and the class level docs refer to what I assume is the
  old name of the option to configure the number of nodes in the test
  cluster

This change addresses the need by:

* Changing the documentation to the new names
@karmi
Copy link
Contributor

karmi commented Nov 19, 2016

Hi @zamith, that's a good catch, thanks! Can you please sign the CLA so I can merge the patch?

@karmi karmi added the waiting label Nov 19, 2016
@zamith
Copy link
Contributor Author

zamith commented Nov 19, 2016

I have signed it. Not sure why it is not showing as signed. Maybe I didn't
sign it with the same email that I have on GitHub. Might that be it?
On Sat, 19 Nov 2016 at 17:02, Karel Minarik [email protected]
wrote:

Hi @zamith https://github.com/zamith, that's a good catch, thanks! Can
you please sign the CLA so I can merge the patch?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#366 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKJoCXUwiwyqXAkw3IOfQRVsQRZkpqfks5q_yuhgaJpZM4KvsVa
.

@karmi
Copy link
Contributor

karmi commented Nov 20, 2016

@zamith, interesting, I was looking into our records and haven't found an unambigous record. Can you send me the e-mail you have used via e-mail? To answer your question, yes, that's what frequently happens, that people sign the CLA with a different e-mail than the one they use in Git, and we can't connect those. The solution is to either add the e-mail used for CLA signature to your Github profile (can be hidden) or change the commit author and force-push.

@zamith
Copy link
Contributor Author

zamith commented Nov 21, 2016

@karmi I just signed it again with my github email.

@zamith
Copy link
Contributor Author

zamith commented Nov 28, 2016

I'm not sure why the tests are failing, since I only changed documentation. Any help?

@karmi karmi closed this in 86fba09 Dec 11, 2016
karmi pushed a commit that referenced this pull request Dec 11, 2016
…option in the documentation

Both the readme and the class level docs refer to what I assume is the
old name of the option to configure the number of nodes in the test
cluster. This change addresses the need.

Closes #366
@karmi
Copy link
Contributor

karmi commented Dec 11, 2016

Thanks for catching this, merged the patch into the master and 5.x branches, many apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants