Skip to content

Bump Node.js from v16 to v20 #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Bump Node.js from v16 to v20 #2492

merged 1 commit into from
Apr 9, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Apr 9, 2024

CI is currently broken because clients-flight-recorder has switched from the EOL v16 to v20. Let's do the same thing here.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin merged commit fe1ef9e into main Apr 9, 2024
8 checks passed
@pquentin pquentin deleted the bump-nodejs branch April 9, 2024 11:46
Copy link
Contributor

github-actions bot commented Apr 9, 2024

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2492-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe1ef9e8cb558e3b0d0e3cb3dd2297847e80b966
# Push it to GitHub
git push --set-upstream origin backport-2492-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2492-to-7.17.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

The backport to 8.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.12 8.12
# Navigate to the new working tree
cd .worktrees/backport-8.12
# Create a new branch
git switch --create backport-2492-to-8.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe1ef9e8cb558e3b0d0e3cb3dd2297847e80b966
# Push it to GitHub
git push --set-upstream origin backport-2492-to-8.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.12

Then, create a pull request where the base branch is 8.12 and the compare/head branch is backport-2492-to-8.12.

github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
pquentin added a commit that referenced this pull request Apr 11, 2024
(cherry picked from commit fe1ef9e)
pquentin added a commit that referenced this pull request Apr 11, 2024
(cherry picked from commit fe1ef9e)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants