-
Notifications
You must be signed in to change notification settings - Fork 97
Bump Node.js from v16 to v20 #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2492-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe1ef9e8cb558e3b0d0e3cb3dd2297847e80b966
# Push it to GitHub
git push --set-upstream origin backport-2492-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.12 8.12
# Navigate to the new working tree
cd .worktrees/backport-8.12
# Create a new branch
git switch --create backport-2492-to-8.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe1ef9e8cb558e3b0d0e3cb3dd2297847e80b966
# Push it to GitHub
git push --set-upstream origin backport-2492-to-8.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.12 Then, create a pull request where the |
(cherry picked from commit fe1ef9e)
(cherry picked from commit fe1ef9e)
(cherry picked from commit fe1ef9e) Co-authored-by: Quentin Pradet <[email protected]>
CI is currently broken because clients-flight-recorder has switched from the EOL v16 to v20. Let's do the same thing here.