Skip to content

Fix property defined in an ancestor class errors #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

pquentin
Copy link
Member

This required removing h and s from the base of cat APIs.

This required removing h and s from the base of cat APIs.
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cat.aliases 🟢 29/29 29/29
cat.allocation 🟢 12/12 12/12
cat.component_templates 🟢 3/3 3/3
cat.count 🟢 9/9 9/9
cat.fielddata 🟢 6/6 6/6
cat.health 🟢 3/3 3/3
cat.indices 🟢 33/33 32/32
cat.master 🟢 1/1 1/1
cat.nodeattrs 🟢 5/5 5/5
cat.nodes 🟢 11/11 11/11
cat.pending_tasks 🟢 1/1 1/1
cat.plugins 🟢 2/2 2/2
cat.recovery 🟢 6/6 6/6
cat.repositories 🟢 6/6 6/6
cat.segments 🟢 9/9 9/9
cat.shards 🟢 11/11 11/11
cat.snapshots 🟢 4/4 4/4
cat.tasks 🟢 11/11 11/11
cat.templates 🟢 17/17 17/17
cat.thread_pool 🟢 9/9 9/9

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 87aaf3c into main Feb 20, 2025
14 checks passed
@pquentin pquentin deleted the cat-ancestor-error branch February 20, 2025 10:07
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3800-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 87aaf3c106ac06b8c1991b4c06050652343eb0d9
# Push it to GitHub
git push --set-upstream origin backport-3800-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3800-to-8.x.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3800-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 87aaf3c106ac06b8c1991b4c06050652343eb0d9
# Push it to GitHub
git push --set-upstream origin backport-3800-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3800-to-8.18.

github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
This required removing h and s from the base of cat APIs.

(cherry picked from commit 87aaf3c)
pquentin added a commit that referenced this pull request Feb 20, 2025
This required removing h and s from the base of cat APIs.

(cherry picked from commit 87aaf3c)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Feb 20, 2025
This required removing h and s from the base of cat APIs.

(cherry picked from commit 87aaf3c)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	output/schema/validation-errors.json
pquentin added a commit that referenced this pull request Feb 20, 2025
This required removing h and s from the base of cat APIs.

(cherry picked from commit 87aaf3c)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	output/schema/validation-errors.json
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x
8.18

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Feb 20, 2025
This required removing h and s from the base of cat APIs.

(cherry picked from commit 87aaf3c)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	output/schema/validation-errors.json
pquentin added a commit that referenced this pull request Feb 20, 2025
This required removing h and s from the base of cat APIs.

(cherry picked from commit 87aaf3c)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	output/schema/validation-errors.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants