Fix queue.max_bytes field in logstash pipeline settings spec
#3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
kaiwenleee
force-pushed
the
fix/logstash-pipeline-settings
branch
2 times, most recently
from
84b7e8c to
c6dd8eb
Compare
kaiwenleee
force-pushed
the
fix/logstash-pipeline-settings
branch
from
9791615 to
a42857e
Compare
kaiwenleee
force-pushed
the
fix/logstash-pipeline-settings
branch
from
a42857e to
599c027
Compare
|
Hello, can any maintainer take a look at the PR, or is there something I'm missing? I did look at the contribution instruction but don't see a clear gap, except that it's no longer possible to do the validation part since |
|
hey @kaiwenleee, thanks for contributing! validation is not starting since it doesn't work for forks, I'll open a mirror PR just to start validation. |
Closed
|
so, turns out we're missing tests for this API ^^" but it looks correct, also this server test confirms it. LGTM, thanks again! |
l-trotta
approved these changes
Apr 12, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2025
Co-authored-by: Wenkai Li <[email protected]> Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 1403bac)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2025
Co-authored-by: Wenkai Li <[email protected]> Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 1403bac)
l-trotta
pushed a commit
that referenced
this pull request
Apr 12, 2025
… (#4273) Co-authored-by: Wenkai Li <[email protected]> Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 1403bac) Co-authored-by: Wenkai <[email protected]>
l-trotta
pushed a commit
that referenced
this pull request
Apr 12, 2025
… (#4274) Co-authored-by: Wenkai Li <[email protected]> Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 1403bac) Co-authored-by: Wenkai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logstash
PipelineSettingsis usingqueue.max_bytessince at least 6.0 rather thanqueue.max_bytes.number&queue.max_bytes.units. This is also shown in the example.Updating the spec so that elasticsearch clients can work correctly.
ref: elastic/elasticsearch#92651