Skip to content

Correct type for policy stats #4471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Correct type for policy stats #4471

merged 2 commits into from
Jun 6, 2025

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Jun 5, 2025

Originally reported in elastic/elasticsearch-java#1021
policy_stats in GetSnapshotLifecycleStatsResponse.ts is currently mapped as a string array, while actually it's a string of SnapshotPolicyStats objects -> server code.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.put_lifecycle 🟢 4/4 4/4
slm.start Missing test Missing test
slm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.put_lifecycle 🟢 4/4 4/4
slm.start Missing test Missing test
slm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit b5e2345 into main Jun 6, 2025
8 checks passed
@l-trotta l-trotta deleted the policy-stats-fix branch June 6, 2025 10:08
github-actions bot pushed a commit that referenced this pull request Jun 6, 2025
* correct type for policy stats

* pretty

(cherry picked from commit b5e2345)
github-actions bot pushed a commit that referenced this pull request Jun 6, 2025
* correct type for policy stats

* pretty

(cherry picked from commit b5e2345)
github-actions bot pushed a commit that referenced this pull request Jun 6, 2025
* correct type for policy stats

* pretty

(cherry picked from commit b5e2345)
l-trotta added a commit that referenced this pull request Jun 6, 2025
* correct type for policy stats

* pretty

(cherry picked from commit b5e2345)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jun 6, 2025
* correct type for policy stats

* pretty

(cherry picked from commit b5e2345)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jun 6, 2025
* correct type for policy stats

* pretty

(cherry picked from commit b5e2345)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants