Skip to content

Validate 'ml.preview_datafeed' API #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Validate 'ml.preview_datafeed' API #516

merged 1 commit into from
Aug 2, 2021

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Jul 29, 2021

Got an error for having an array of TDocument as a response body:

> [email protected] generate-schema /home/sethmlarson/elasticsearch-specification/compiler
> ts-node index.ts

Error: Children should be PropertySignature or PropertyDeclaration but is TypeReference instead
At: /home/sethmlarson/elasticsearch-specification/specification/ml/preview_datafeed/MlPreviewDatafeedResponse.ts:21:8

19  
20  export class Response<TDocument> {
21    body: TDocument[]
22  }
23  

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] generate-schema: `ts-node index.ts`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] generate-schema script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/sethmlarson/.npm/_logs/2021-07-29T19_21_45_101Z-debug.log
Makefile:38: recipe for target 'spec-generate' failed
make: *** [spec-generate] Error 1

Closes #377

@sethmlarson sethmlarson force-pushed the ml-preview-datafeed branch from 9f76a2f to 4cb4cf8 Compare July 30, 2021 14:43
@sethmlarson sethmlarson requested a review from delvedor July 30, 2021 14:43
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit 936cc9a into main Aug 2, 2021
@delvedor delvedor deleted the ml-preview-datafeed branch August 2, 2021 12:39
delvedor added a commit that referenced this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ML datafeed_preview needs updating
2 participants