Update type selection for string parameters #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking 'proper', the build script now invokes the build scripts for both x86 and x64, if any of them are present.
wmi application used to uninstall driver by name during integration testing can take over 1.5 minutes on slower VMs with many installed applications.
When extended logging debugging define is enabled, the hex dumping of binary buffers (used for CBOR replies logging) are now also dynamically allocated and significantly larger (4k -> 4M). This allows easier troubleshooting.
This commit changes the way a parameter's SQL type is resolved to an ES type. So far, the size of the parameter was taking into account, to select the ES type with the lowest "precision" that would accomodate it. This worked well so far because IP type was having a precision of 0. This precision for IP type had been updated in Elasticsearch (to maximum IP length), which would lead to the driver tagging small length strings as IP types. With current change, all string type parameterss are considered as TEXT types, leaving Elasticsearch/SQL to apply a better, context-informed conversion.
bpintea
added a commit
that referenced
this pull request
Mar 30, 2020
* proper cleans all builds When invoking 'proper', the build script now invokes the build scripts for both x86 and x64, if any of them are present. * inc uninstallation timeout while integ-testing wmi application used to uninstall driver by name during integration testing can take over 1.5 minutes on slower VMs with many installed applications. * extend logging buffers for (CBOR) hex printers When extended logging debugging define is enabled, the hex dumping of binary buffers (used for CBOR replies logging) are now also dynamically allocated and significantly larger (4k -> 4M). This allows easier troubleshooting. * change the ES type selection for text parameters This commit changes the way a parameter's SQL type is resolved to an ES type. So far, the size of the parameter was taking into account, to select the ES type with the lowest "precision" that would accomodate it. This worked well so far because IP type was having a precision of 0. This precision for IP type had been updated in Elasticsearch (to maximum IP length), which would lead to the driver tagging small length strings as IP types. With current change, all string type parameterss are considered as TEXT types, leaving Elasticsearch/SQL to apply a better, context-informed conversion. (cherry picked from commit 290e287)
bpintea
added a commit
that referenced
this pull request
Mar 30, 2020
* proper cleans all builds When invoking 'proper', the build script now invokes the build scripts for both x86 and x64, if any of them are present. * inc uninstallation timeout while integ-testing wmi application used to uninstall driver by name during integration testing can take over 1.5 minutes on slower VMs with many installed applications. * extend logging buffers for (CBOR) hex printers When extended logging debugging define is enabled, the hex dumping of binary buffers (used for CBOR replies logging) are now also dynamically allocated and significantly larger (4k -> 4M). This allows easier troubleshooting. * change the ES type selection for text parameters This commit changes the way a parameter's SQL type is resolved to an ES type. So far, the size of the parameter was taking into account, to select the ES type with the lowest "precision" that would accomodate it. This worked well so far because IP type was having a precision of 0. This precision for IP type had been updated in Elasticsearch (to maximum IP length), which would lead to the driver tagging small length strings as IP types. With current change, all string type parameterss are considered as TEXT types, leaving Elasticsearch/SQL to apply a better, context-informed conversion. (cherry picked from commit 290e287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way a parameter's SQL type is resolved to an ES
type. So far, the size of the parameter was taken into account, to
select the ES type with the lowest "precision" that would accomodate it.
This worked well so far because IP type was having a precision of 0 (=ignored).
This precision for IP type had been updated in Elasticsearch (to maximum
IP length), which would lead to the driver tagging small length strings
as IP types.
With current change, all string type parameterss are considered as TEXT
types, leaving Elasticsearch/SQL to apply a better, context-informed
conversion.
The PR also extends the size of binary-to-hexa logging and does a better
cleaning with "proper" build script parameter.