Skip to content

Commit 1927c6e

Browse files
authored
Fix deploying custom models with adaptive allocations (#126276)
1 parent a4a2714 commit 1927c6e

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/elasticsearch/CustomElandInternalTextEmbeddingServiceSettings.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ private static CommonFields commonFieldsFromMap(Map<String, Object> map, Validat
107107
private final DenseVectorFieldMapper.ElementType elementType;
108108

109109
CustomElandInternalTextEmbeddingServiceSettings(
110-
int numAllocations,
110+
Integer numAllocations,
111111
int numThreads,
112112
String modelId,
113113
AdaptiveAllocationsSettings adaptiveAllocationsSettings,

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/elasticsearch/CustomElandInternalTextEmbeddingServiceSettingsTests.java

+9-8
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import org.elasticsearch.xcontent.XContentBuilder;
1616
import org.elasticsearch.xcontent.XContentFactory;
1717
import org.elasticsearch.xcontent.XContentType;
18+
import org.elasticsearch.xpack.core.ml.inference.assignment.AdaptiveAllocationsSettings;
1819
import org.elasticsearch.xpack.inference.services.ConfigurationParseContext;
1920
import org.elasticsearch.xpack.inference.services.ServiceFields;
2021

@@ -31,23 +32,23 @@ public class CustomElandInternalTextEmbeddingServiceSettingsTests extends Abstra
3132
CustomElandInternalTextEmbeddingServiceSettings> {
3233

3334
public static CustomElandInternalTextEmbeddingServiceSettings createRandom() {
34-
var numAllocations = randomIntBetween(1, 10);
35+
var withAdaptiveAllocations = randomBoolean();
36+
var numAllocations = withAdaptiveAllocations ? null : randomIntBetween(1, 10);
37+
var adaptiveAllocationsSettings = withAdaptiveAllocations
38+
? new AdaptiveAllocationsSettings(true, randomIntBetween(0, 2), randomIntBetween(2, 5))
39+
: null;
3540
var numThreads = randomIntBetween(1, 10);
3641
var modelId = randomAlphaOfLength(8);
37-
SimilarityMeasure similarityMeasure = SimilarityMeasure.COSINE;
38-
Integer dims = null;
42+
var similarityMeasure = SimilarityMeasure.COSINE;
3943
var setDimensions = randomBoolean();
40-
if (setDimensions) {
41-
dims = 123;
42-
}
43-
44+
var dims = setDimensions ? 123 : null;
4445
var elementType = randomFrom(DenseVectorFieldMapper.ElementType.values());
4546

4647
return new CustomElandInternalTextEmbeddingServiceSettings(
4748
numAllocations,
4849
numThreads,
4950
modelId,
50-
null,
51+
adaptiveAllocationsSettings,
5152
null,
5253
dims,
5354
similarityMeasure,

0 commit comments

Comments
 (0)