Fix deploying custom models with adaptive allocations #126276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-elastic
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
jan-elastic
commented
Apr 4, 2025
| @@ -107,7 +107,7 @@ private static CommonFields commonFieldsFromMap(Map<String, Object> map, Validat | |||
| private final DenseVectorFieldMapper.ElementType elementType; | |||
|
|
|||
| CustomElandInternalTextEmbeddingServiceSettings( | |||
| int numAllocations, | |||
| Integer numAllocations, | |||
There was a problem hiding this comment.
Setting adaptive allocations (and thereby passing numAllocations = null) currently doesn't work for custom models. The parent constructor also has Integer numAllocations.
jonathan-buttner
approved these changes
Apr 4, 2025
jan-elastic
added
the
auto-merge-without-approval
This was referenced Apr 4, 2025
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Apr 4, 2025
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Apr 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.