Skip to content

Commit 1f6497e

Browse files
committed
Fix cases where we would unintentionally tar the entire build workspace (#49130)
Fix cases where we would unintentionally tar the entire build workspace
1 parent d6f2903 commit 1f6497e

File tree

1 file changed

+28
-24
lines changed

1 file changed

+28
-24
lines changed

gradle/build-complete.gradle

Lines changed: 28 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,32 +3,36 @@ import java.nio.file.Files
33
String buildNumber = System.getenv('BUILD_NUMBER')
44

55
if (buildNumber) {
6-
File uploadFile = file("build/${buildNumber}.tar.bz2")
7-
project.gradle.buildFinished { result ->
8-
println "build complete, generating: $uploadFile"
9-
if (uploadFile.exists()) {
10-
project.delete(uploadFile)
11-
}
12-
13-
try {
14-
ant.tar(destfile: uploadFile, compression: "bzip2", longfile: "gnu") {
15-
fileset(dir: projectDir) {
16-
fileTree(projectDir)
17-
.include("**/*.hprof")
18-
.include("**/reaper.log")
19-
.include("**/build/testclusters/**/logs/**")
20-
.filter { Files.isRegularFile(it.toPath()) }
21-
.each {
22-
include(name: projectDir.toPath().relativize(it.toPath()))
23-
}
24-
}
6+
File uploadFile = file("build/${buildNumber}.tar.bz2")
7+
project.gradle.buildFinished { result ->
8+
println "build complete, generating: $uploadFile"
9+
if (uploadFile.exists()) {
10+
project.delete(uploadFile)
11+
}
2512

26-
fileset(dir: "${gradle.gradleUserHomeDir}/daemon/${gradle.gradleVersion}", followsymlinks: false) {
27-
include(name: "**/daemon-${ProcessHandle.current().pid()}*.log")
28-
}
13+
try {
14+
ant.tar(destfile: uploadFile, compression: "bzip2", longfile: "gnu") {
15+
fileset(dir: projectDir) {
16+
fileTree(projectDir)
17+
.include("**/*.hprof")
18+
.include("**/reaper.log")
19+
.include("**/build/testclusters/**")
20+
.exclude("**/build/testclusters/**/data/**")
21+
.exclude("**/build/testclusters/**/distro/**")
22+
.exclude("**/build/testclusters/**/repo/**")
23+
.exclude("**/build/testclusters/**/extract/**")
24+
.filter { Files.isRegularFile(it.toPath()) }
25+
.each {
26+
include(name: projectDir.toPath().relativize(it.toPath()))
2927
}
30-
} catch (Exception e) {
31-
logger.lifecycle("Failed to archive additional logs", e)
3228
}
29+
30+
fileset(dir: "${gradle.gradleUserHomeDir}/daemon/${gradle.gradleVersion}", followsymlinks: false) {
31+
include(name: "**/daemon-${ProcessHandle.current().pid()}*.log")
32+
}
33+
}
34+
} catch (Exception e) {
35+
logger.lifecycle("Failed to archive additional logs", e)
3336
}
37+
}
3438
}

0 commit comments

Comments
 (0)