Fix cases where we would unintentionally tar the entire build workspace #49130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <[email protected]>
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Signed-off-by: Mark Vieira <[email protected]>
mark-vieira
added a commit
that referenced
this pull request
Nov 15, 2019
…ce (#49130) Fix cases where we would unintentionally tar the entire build workspace
mark-vieira
added a commit
that referenced
this pull request
Nov 15, 2019
…ce (#49130) Fix cases where we would unintentionally tar the entire build workspace
mark-vieira
added a commit
that referenced
this pull request
Nov 15, 2019
…ce (#49130) Fix cases where we would unintentionally tar the entire build workspace
mark-vieira
added a commit
that referenced
this pull request
Nov 20, 2019
mark-vieira
added a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently started noticing that end of build had increased substantially. This is attributed to the
buildFinishedhook that packs up certain log files and test output and uploads to GCP for later retrieval if needed. There seemed to be some issue with the logic here that would cause the entire build workspace to be included in the bundle. One scenario in which this could happen is if our included filters didn't match any files, in which case we wouldn't add any filters to our Ant fileset, so by default this would include the entire workspace. Essentially, this happens for any build that doesn't spin up elasticsearch clusters via testclusters. For such a build, none of the workspace files would match our criteria and the default behavior would kick in.We began to observe this behavior after #48732 was merged. The reason was that for any given build we would at least include the
journalctl.logfile created in the build workspace. When that was removed, certain builds (those that didn't leverage testclusters) would now not match any files and Ant would default to the "include all" strategy.