Skip to content

Commit aa43e0b

Browse files
authored
[Zen2] Migrate no-master-block integration tests (#36502)
This change follows up on #36478 by migrating the affected integration tests to use Zen2.
1 parent 883940a commit aa43e0b

File tree

4 files changed

+145
-118
lines changed

4 files changed

+145
-118
lines changed

modules/transport-netty4/src/test/java/org/elasticsearch/rest/discovery/Zen2RestApiIT.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
import org.elasticsearch.common.settings.Settings.Builder;
3737
import org.elasticsearch.common.unit.TimeValue;
3838
import org.elasticsearch.discovery.zen.ElectMasterService;
39-
import org.elasticsearch.gateway.GatewayService;
4039
import org.elasticsearch.http.HttpServerTransport;
4140
import org.elasticsearch.test.ESIntegTestCase;
4241
import org.elasticsearch.test.InternalTestCluster;
@@ -59,7 +58,6 @@ public class Zen2RestApiIT extends ESNetty4IntegTestCase {
5958
protected Settings nodeSettings(int nodeOrdinal) {
6059
final Builder builder = Settings.builder().put(super.nodeSettings(nodeOrdinal))
6160
.put(TestZenDiscovery.USE_ZEN2.getKey(), true)
62-
.put(GatewayService.RECOVER_AFTER_MASTER_NODES_SETTING.getKey(), 1)
6361
.put(ElectMasterService.DISCOVERY_ZEN_MINIMUM_MASTER_NODES_SETTING.getKey(), Integer.MAX_VALUE);
6462

6563
if (nodeOrdinal == 0) {

server/src/main/java/org/elasticsearch/gateway/GatewayService.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import org.elasticsearch.common.unit.TimeValue;
4141
import org.elasticsearch.common.util.concurrent.AbstractRunnable;
4242
import org.elasticsearch.discovery.Discovery;
43+
import org.elasticsearch.discovery.zen.ZenDiscovery;
4344
import org.elasticsearch.indices.IndicesService;
4445
import org.elasticsearch.rest.RestStatus;
4546
import org.elasticsearch.threadpool.ThreadPool;
@@ -115,9 +116,10 @@ public GatewayService(final Settings settings, final AllocationService allocatio
115116
// default the recover after master nodes to the minimum master nodes in the discovery
116117
if (RECOVER_AFTER_MASTER_NODES_SETTING.exists(settings)) {
117118
recoverAfterMasterNodes = RECOVER_AFTER_MASTER_NODES_SETTING.get(settings);
118-
} else {
119-
// TODO: change me once the minimum_master_nodes is changed too
119+
} else if (discovery instanceof ZenDiscovery) {
120120
recoverAfterMasterNodes = settings.getAsInt("discovery.zen.minimum_master_nodes", -1);
121+
} else {
122+
recoverAfterMasterNodes = -1;
121123
}
122124

123125
if (discovery instanceof Coordinator) {

0 commit comments

Comments
 (0)