[Zen2] Migrate no-master-block integration tests #36502
Conversation
This change follows up on elastic#36478 by migrating the affected integration tests to use Zen2.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed |
| .put(DiscoverySettings.NO_MASTER_BLOCK_SETTING.getKey(), "all") | ||
| .build(); | ||
| .put(AutoCreateIndex.AUTO_CREATE_INDEX_SETTING.getKey(), true) | ||
| .put(ElectMasterService.DISCOVERY_ZEN_MINIMUM_MASTER_NODES_SETTING.getKey(), Integer.MAX_VALUE) |
There was a problem hiding this comment.
Is it possible to get rid of this setting, because we're running Zen2 and not Zen? Or should it stay until Zen is completely removed?
There was a problem hiding this comment.
Unfortunately today InternalTestCluster currently requires that it's explicitly set if autoMinMasterNodes is false, which is why it's present but set ludicrously high. Once we've finished migrating everything to Zen2 it will be easy enough to find all usages like this to remove them.
| .put(DiscoverySettings.NO_MASTER_BLOCK_SETTING.getKey(), "write") | ||
| .build(); | ||
| .put(AutoCreateIndex.AUTO_CREATE_INDEX_SETTING.getKey(), false) | ||
| .put(ElectMasterService.DISCOVERY_ZEN_MINIMUM_MASTER_NODES_SETTING.getKey(), Integer.MAX_VALUE) |
There was a problem hiding this comment.
Is it possible to get rid of this setting, because we're running Zen2 and not Zen? Or should it stay until Zen is completely removed?
|
@elasticmachine please run the Gradle build tests 2 |
| .build(); | ||
| .put(AutoCreateIndex.AUTO_CREATE_INDEX_SETTING.getKey(), true) | ||
| .put(ElectMasterService.DISCOVERY_ZEN_MINIMUM_MASTER_NODES_SETTING.getKey(), Integer.MAX_VALUE) | ||
| .put(GatewayService.RECOVER_AFTER_MASTER_NODES_SETTING.getKey(), 3) |
There was a problem hiding this comment.
why add this setting? This should not be needed?
There was a problem hiding this comment.
It defaults to whatever minimum_master_nodes is. I could just set that to 3.
There was a problem hiding this comment.
ah that's annoying, and does not make any sense in Zen2. Can you perhaps change GatewayService to not do this if discovery instanceof Coordinator?
There was a problem hiding this comment.
Ok, I pushed b0e9643.
| .build(); | ||
| .put(AutoCreateIndex.AUTO_CREATE_INDEX_SETTING.getKey(), false) | ||
| .put(ElectMasterService.DISCOVERY_ZEN_MINIMUM_MASTER_NODES_SETTING.getKey(), Integer.MAX_VALUE) | ||
| .put(GatewayService.RECOVER_AFTER_MASTER_NODES_SETTING.getKey(), 3) |
There was a problem hiding this comment.
same here. Why is this needed?
|
Apparently-unrelated failures. @elasticmachine please run the gradle build tests 1 |
This change follows up on #36478 by migrating the affected integration tests to
use Zen2.