Skip to content

Commit fb5071c

Browse files
authored
[ML] Disallow wildcarded deletions in ML native tests again (#73721)
After #71150 was merged we had to allow wildcarded deletions in our native multi-node tests, because the feature reset API was doing a wildcarded deletion. This is not ideal because we then might rely on wildcarded deletion somewhere else and not notice in our tests. Now that #73017 is merged we should no longer need to allow wildcarded deletion for the benefit of the feature reset API. Therefore, this PR reverts the setting change that was made in #71176. Over time our testing will then validate that the feature reset API really does work with wildcarded deletes disallowed.
1 parent 91db107 commit fb5071c

File tree

1 file changed

+0
-2
lines changed
  • x-pack/plugin/ml/qa/native-multi-node-tests/src/javaRestTest/java/org/elasticsearch/xpack/ml/integration

1 file changed

+0
-2
lines changed

x-pack/plugin/ml/qa/native-multi-node-tests/src/javaRestTest/java/org/elasticsearch/xpack/ml/integration/MlNativeIntegTestCase.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import org.elasticsearch.action.admin.cluster.snapshots.features.ResetFeatureStateAction;
1010
import org.elasticsearch.action.admin.cluster.snapshots.features.ResetFeatureStateRequest;
11-
import org.elasticsearch.action.support.DestructiveOperations;
1211
import org.elasticsearch.cluster.NamedDiff;
1312
import org.elasticsearch.xpack.autoscaling.Autoscaling;
1413
import org.elasticsearch.xpack.autoscaling.AutoscalingMetadata;
@@ -169,7 +168,6 @@ protected Settings externalClusterClientSettings() {
169168

170169
Settings.Builder builder = Settings.builder();
171170
builder.putList("node.roles", Collections.emptyList());
172-
builder.put(DestructiveOperations.REQUIRES_NAME_SETTING.getKey(), false);
173171
builder.put(NetworkModule.TRANSPORT_TYPE_KEY, SecurityField.NAME4);
174172
builder.put(XPackSettings.MACHINE_LEARNING_ENABLED.getKey(), true);
175173
builder.put(XPackSettings.SECURITY_ENABLED.getKey(), true);

0 commit comments

Comments
 (0)