[ML] Disallow wildcarded deletions in ML native tests again #73721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After elastic#71150 was merged we had to allow wildcarded deletions in our native multi-node tests, because the feature reset API was doing a wildcarded deletion. This is not ideal because we then might rely on wildcarded deletion somewhere else and not notice in our tests. Now that elastic#73017 is merged we should no longer need to allow wildcarded deletion for the benefit of the feature reset API. Therefore, this PR reverts the setting change that was made in elastic#71176. Over time our testing will then validate that the feature reset API really does work with wildcarded deletes disallowed.
droberts195
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
droberts195
added a commit
that referenced
this pull request
Jun 4, 2021
After #71150 was merged we had to allow wildcarded deletions in our native multi-node tests, because the feature reset API was doing a wildcarded deletion. This is not ideal because we then might rely on wildcarded deletion somewhere else and not notice in our tests. Now that #73017 is merged we should no longer need to allow wildcarded deletion for the benefit of the feature reset API. Therefore, this PR reverts the setting change that was made in #71176. Over time our testing will then validate that the feature reset API really does work with wildcarded deletes disallowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #71150 was merged we had to allow wildcarded deletions
in our native multi-node tests, because the feature reset API
was doing a wildcarded deletion.
This is not ideal because we then might rely on wildcarded
deletion somewhere else and not notice in our tests.
Now that #73017 is merged we should no longer need to allow
wildcarded deletion for the benefit of the feature reset API.
Therefore, this PR reverts the setting change that was made
in #71176. Over time our testing will then validate that the
feature reset API really does work with wildcarded deletes
disallowed.