Improve module/plugin loading logging message order. (#93952)

Author: howardhuanghua

docs/changelog/93952.yaml

@@ -0,0 +1,5 @@
+pr: 93952
+summary: Improve module/plugin loading logging message.
+area: Infra/Plugins 
+type: enhancement
+issues: [93881]

server/src/main/java/org/elasticsearch/plugins/PluginsService.java

@@ -132,10 +132,14 @@ public PluginsService(Settings settings, Path configPath, Path modulesDirectory,
 
         // load modules
         List<PluginDescriptor> modulesList = new ArrayList<>();
+        Set<String> moduleNameList = new HashSet<>();
         if (modulesDirectory != null) {
             try {
                 Set<PluginBundle> modules = PluginsUtils.getModuleBundles(modulesDirectory);
-                modules.stream().map(PluginBundle::pluginDescriptor).forEach(modulesList::add);
+                modules.stream().map(PluginBundle::pluginDescriptor).forEach(m -> {
+                    modulesList.add(m);
+                    moduleNameList.add(m.getName());
+                });
                 seenBundles.addAll(modules);
             } catch (IOException ex) {
                 throw new IllegalStateException("Unable to initialize modules", ex);
@@ -173,8 +177,13 @@ public PluginsService(Settings settings, Path configPath, Path modulesDirectory,
 
         // we don't log jars in lib/ we really shouldn't log modules,
         // but for now: just be transparent so we can debug any potential issues
-        logPluginInfo(info.getModuleInfos(), "module", logger);
-        logPluginInfo(pluginsList, "plugin", logger);
+        for (String name : loadedPlugins.keySet()) {
+            if (moduleNameList.contains(name)) {
+                logger.info("loaded module [{}]", name);
+            } else {
+                logger.info("loaded plugin [{}]", name);
+            }
+        }
     }
 
     // package-private for testing
@@ -194,17 +203,6 @@ static void checkMandatoryPlugins(Set<String> existingPlugins, Set<String> manda
         }
     }
 
-    private static void logPluginInfo(final List<PluginDescriptor> pluginDescriptors, final String type, final Logger logger) {
-        assert pluginDescriptors != null;
-        if (pluginDescriptors.isEmpty()) {
-            logger.info("no " + type + "s loaded");
-        } else {
-            for (final String name : pluginDescriptors.stream().map(PluginDescriptor::getName).sorted().toList()) {
-                logger.info("loaded " + type + " [" + name + "]");
-            }
-        }
-    }
-
     private static List<PluginRuntimeInfo> getRuntimeInfos(
         PluginIntrospector inspector,
         List<PluginDescriptor> pluginDescriptors,