Skip to content

Improve module/plugin loading logging message. #93952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 23, 2023
Merged

Improve module/plugin loading logging message. #93952

merged 4 commits into from
Feb 23, 2023

Conversation

howardhuanghua
Copy link
Contributor

@howardhuanghua howardhuanghua commented Feb 21, 2023 •
edited
Loading

This PR going to fix #93881.
Print plugin/module loading message in order.

Here is the log output demo for loaded modules/plugins in dependency sorted order.

[2023-02-21T10:18:56,791][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [repository-url]
[2023-02-21T10:18:56,808][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [ingest-user-agent]
[2023-02-21T10:18:56,812][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-core]
[2023-02-21T10:18:56,815][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-async-search]
[2023-02-21T10:18:56,816][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-monitoring]
[2023-02-21T10:18:56,816][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [repository-s3]
[2023-02-21T10:18:56,819][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-analytics]
[2023-02-21T10:18:56,826][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-autoscaling]
[2023-02-21T10:18:56,827][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [lang-painless]
[2023-02-21T10:18:56,829][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-ml]
[2023-02-21T10:18:56,854][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [lang-mustache]
[2023-02-21T10:18:56,856][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [legacy-geo]
[2023-02-21T10:18:56,860][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-ql]
[2023-02-21T10:18:56,878][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [analysis-common]
[2023-02-21T10:18:56,879][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [transport-netty4]
[2023-02-21T10:18:56,894][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [aggregations]
[2023-02-21T10:18:56,915][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [ingest-common]
[2023-02-21T10:18:56,919][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [frozen-indices]
[2023-02-21T10:18:56,949][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-identity-provider]
[2023-02-21T10:18:56,957][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-shutdown]
[2023-02-21T10:18:56,959][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-text-structure]
[2023-02-21T10:18:56,989][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [snapshot-repo-test-kit]
[2023-02-21T10:18:56,995][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [kibana]
[2023-02-21T10:18:57,014][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [constant-keyword]
[2023-02-21T10:18:57,015][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [aggs-matrix-stats]
[2023-02-21T10:18:57,031][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-logstash]
[2023-02-21T10:18:57,036][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-ccr]
[2023-02-21T10:18:57,038][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-graph]
[2023-02-21T10:18:57,056][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [parent-join]
[2023-02-21T10:18:57,062][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-enrich]
[2023-02-21T10:18:57,067][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [repositories-metering-api]
[2023-02-21T10:18:57,089][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [transform]
[2023-02-21T10:18:57,110][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [repository-azure]
[2023-02-21T10:18:57,112][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [repository-gcs]
[2023-02-21T10:18:57,127][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [spatial]
[2023-02-21T10:18:57,152][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [apm]
[2023-02-21T10:18:57,155][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [mapper-extras]
[2023-02-21T10:18:57,156][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [mapper-version]
[2023-02-21T10:18:57,183][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-aggregate-metric]
[2023-02-21T10:18:57,222][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-rollup]
[2023-02-21T10:18:57,247][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [percolator]
[2023-02-21T10:18:57,254][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [data-streams]
[2023-02-21T10:18:57,262][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-stack]
[2023-02-21T10:18:57,285][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [rank-eval]
[2023-02-21T10:18:57,327][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [reindex]
[2023-02-21T10:18:57,338][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [repository-encrypted]
[2023-02-21T10:18:57,370][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-security]
[2023-02-21T10:18:57,372][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [searchable-snapshots]
[2023-02-21T10:18:57,401][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [snapshot-based-recoveries]
[2023-02-21T10:18:57,428][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-watcher]
[2023-02-21T10:18:57,434][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [old-lucene-versions]
[2023-02-21T10:18:57,466][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-ilm]
[2023-02-21T10:18:57,473][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-voting-only-node]
[2023-02-21T10:18:57,510][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-deprecation]
[2023-02-21T10:18:57,517][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-fleet]
[2023-02-21T10:18:57,520][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [ingest-geoip]
[2023-02-21T10:18:57,535][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-write-load-forecaster]
[2023-02-21T10:18:57,541][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [search-business-rules]
[2023-02-21T10:18:57,558][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [ingest-attachment]
[2023-02-21T10:18:57,561][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [wildcard]
[2023-02-21T10:18:57,562][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [unsigned-long]
[2023-02-21T10:18:57,582][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-sql]
[2023-02-21T10:18:57,586][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [runtime-fields-common]
[2023-02-21T10:18:57,615][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-async]
[2023-02-21T10:18:57,617][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [vector-tile]
[2023-02-21T10:18:57,629][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [lang-expression]
[2023-02-21T10:18:57,629][INFO ][o.e.p.PluginsService     ] [PC0] loaded module [x-pack-eql]
[2023-02-21T10:18:57,647][INFO ][o.e.p.PluginsService     ] [PC0] loaded plugin [analysis-pinyin]
[2023-02-21T10:18:57,652][INFO ][o.e.p.PluginsService     ] [PC0] loaded plugin [analysis-ik]

@howardhuanghua howardhuanghua changed the title Improve module/plugin loading logging. Improve module/plugin loading logging message. Feb 21, 2023
@elasticsearchmachine
Copy link
Collaborator

@howardhuanghua please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Feb 21, 2023
@thecoop thecoop added :Core/Infra/Core Core issues without another label :Core/Infra/Plugins Plugin API and infrastructure external-contributor Pull request authored by a developer outside the Elasticsearch team and removed :Core/Infra/Core Core issues without another label labels Feb 22, 2023
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team and removed needs:triage Requires assignment of a team area label labels Feb 22, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

1 similar comment
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@thecoop thecoop added v8.8.0 and removed Team:Core/Infra Meta label for core/infra team labels Feb 22, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 22, 2023
@thecoop thecoop added >enhancement and removed Team:Core/Infra Meta label for core/infra team labels Feb 22, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 22, 2023
thecoop
thecoop reviewed Feb 22, 2023
View reviewed changes
@thecoop
Copy link
Member

thecoop commented Feb 22, 2023 •
edited
Loading

Thanks for the PR. Looks ok, just added one comment.

Could you update your branch from latest main? In particular, we've merged in a change to maintain plugin ordering (#93882), which duplicates a couple of lines in this PR.

@thecoop thecoop self-assigned this Feb 22, 2023
@howardhuanghua
Copy link
Contributor Author

Hi @thecoop, thanks for checking. I have updated the latest main and fixed the comment.

@thecoop
Copy link
Member

thecoop commented Feb 23, 2023

@elasticsearchmachine test this please

@thecoop
Copy link
Member

thecoop commented Feb 23, 2023

@howardhuanghua could you change the changelog area field to Infra/Plugins? There's only a fixed set of constants valid for that field.

@howardhuanghua
Copy link
Contributor Author

@howardhuanghua could you change the changelog area field to Infra/Plugins? There's only a fixed set of constants valid for that field.

Done.

@thecoop
Copy link
Member

thecoop commented Feb 23, 2023

@elasticsearchmachine test this please

thecoop
thecoop approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@thecoop thecoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit fbb7913 into elastic:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoop thecoop thecoop approved these changes

Assignees

@thecoop thecoop

Labels
:Core/Infra/Plugins Plugin API and infrastructure >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve module/plugin loading logging messages
3 participants
@howardhuanghua @elasticsearchmachine @thecoop