Skip to content

RepositoryAnalyzeAction.AsyncAction#isRunning should not check for cancellation #101197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DaveCTurner opened this issue Oct 23, 2023 · 1 comment · Fixed by #101213
Closed

RepositoryAnalyzeAction.AsyncAction#isRunning should not check for cancellation #101197

DaveCTurner opened this issue Oct 23, 2023 · 1 comment · Fixed by #101213
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >tech debt

Comments

@DaveCTurner
Copy link
Contributor

Instead we should use org.elasticsearch.tasks.CancellableTask#addListener to add a listener which sets failure on cancellation.
@DaveCTurner DaveCTurner added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >tech debt labels Oct 23, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Oct 23, 2023
This was referenced Oct 23, 2023
Merged
Merged
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Oct 23, 2023
@DaveCTurner
Improve cancellation in repo analysis
943f0d8 
Today we rely on an `isRunning` check to check for task cancellation,
but since elastic#82685 we can actively record the failure arising from the
cancellation using a `CancellationListener`.

Closes elastic#101197
DaveCTurner added a commit that referenced this issue Oct 24, 2023
@DaveCTurner
Improve cancellation in repo analysis (#101213)
b714549 
Today we rely on an `isRunning` check to check for task cancellation,
but since #82685 we can actively record the failure arising from the
cancellation using a `CancellationListener`.

Closes #101197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve cancellation in repo analysis DaveCTurner/elasticsearch
2 participants
@DaveCTurner @elasticsearchmachine