-
Notifications
You must be signed in to change notification settings - Fork 25.2k
API Change: put_mapping: change default ignore_conflicts to false #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
API Change: put_mapping: change default ignore_conflicts to false, closed by 52f193c. |
tlrx
added a commit
that referenced
this issue
Jun 5, 2015
rmuir
pushed a commit
to rmuir/elasticsearch
that referenced
this issue
Nov 8, 2015
Our package naming for tests is inconsistent. We should move tests from: * `o.e.index.mapper.xcontent` to `o.e.index.mapper.attachment.test.unit` * `o.e.plugin.mapper.attachments.test` to `o.e.index.mapper.attachment.test.integration` * `StandaloneRunner` class to `o.e.index.mapper.attachment.test.standalone` Also rename resource dirs to match the test name so it's definitely easier to find mappings used for each test. Closes elastic#110.
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this issue
Oct 2, 2023
With this commit we use the user home directory to render `rally.ini` from the Ansible fixture that configures Rally. For the production case (where we're running as user `jenkins`) we still resort to the current home directory. Relates elastic#110
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In keeping with my comment about having options default to
false
, and having to "enable" features with atrue
value, perhapsignoreConflicts
should be renamed towarn_on_conflict
Actually, thinking about it more, I think that
ignore_conflicts
is the right name, but that it should default tofalse
. Silently ignoring a problem seems like the wrong approach. I'd rather have to take the decision to ignore it myself.The text was updated successfully, but these errors were encountered: