Skip to content

[CI] CoreWithMultipleProjectsClientYamlTestSuiteIT test {yaml=search.vectors/41_knn_search_bbq_hnsw/Vector rescoring has same scoring as exact search for kNN section} failing #124052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elasticsearchmachine opened this issue Mar 4, 2025 · 10 comments
Assignees
Labels
low-risk An open issue or test failure that is a low risk to future releases :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

Build Scans:

Reproduction Line:

./gradlew ":x-pack:qa:multi-project:core-rest-tests-with-multiple-projects:yamlRestTest" --tests "org.elasticsearch.multiproject.test.CoreWithMultipleProjectsClientYamlTestSuiteIT" -Dtests.method="test {yaml=search.vectors/41_knn_search_bbq_hnsw/Vector rescoring has same scoring as exact search for kNN section}" -Dtests.seed=DF1DDE5C4B469CD5 -Dtests.jvm.argline="-Des.entitlements.enabled=true" -Dtests.locale=ksf-Latn-CM -Dtests.timezone=Etc/GMT+3 -Druntime.java=21

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: Failure at [search.vectors/41_knn_search_bbq_hnsw:171]: 
Expected: <3>
     but: was <2>

Issue Reasons:

  • [main] 3 failures in test test {yaml=search.vectors/41_knn_search_bbq_hnsw/Vector rescoring has same scoring as exact search for kNN section} (1.1% fail rate in 278 executions)
  • [main] 2 failures in step part-2 (1.7% fail rate in 116 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (1.7% fail rate in 118 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.

@elasticsearchmachine elasticsearchmachine added :Delivery/Build Build or test infrastructure >test-failure Triaged test failures from CI labels Mar 4, 2025
elasticsearchmachine added a commit that referenced this issue Mar 4, 2025
…ntYamlTestSuiteIT test {yaml=search.vectors/41_knn_search_bbq_hnsw/Vector rescoring has same scoring as exact search for kNN section} #124052
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 3 failures in test test {yaml=search.vectors/41_knn_search_bbq_hnsw/Vector rescoring has same scoring as exact search for kNN section} (1.1% fail rate in 278 executions)
  • [main] 2 failures in step part-2 (1.7% fail rate in 116 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (1.7% fail rate in 118 executions)

Build Scans:

@elasticsearchmachine elasticsearchmachine added Team:Delivery Meta label for Delivery team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Mar 4, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-delivery (Team:Delivery)

dnhatn pushed a commit to dnhatn/elasticsearch that referenced this issue Mar 5, 2025
…ntYamlTestSuiteIT test {yaml=search.vectors/41_knn_search_bbq_hnsw/Vector rescoring has same scoring as exact search for kNN section} elastic#124052
@benwtrent benwtrent added :Search Relevance/Vectors Vector search and removed :Delivery/Build Build or test infrastructure labels Mar 5, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Delivery Meta label for Delivery team labels Mar 5, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@thecoop
Copy link
Member

thecoop commented Mar 10, 2025

@carlosdelest This is from #116663 - it doesnt reproduce locally...

georgewallace pushed a commit to georgewallace/elasticsearch that referenced this issue Mar 11, 2025
…ntYamlTestSuiteIT test {yaml=search.vectors/41_knn_search_bbq_hnsw/Vector rescoring has same scoring as exact search for kNN section} elastic#124052
@benwtrent
Copy link
Member

This is really weird. There is something wrong here. This failure is on the scriptScore query, not returning 3 hits. This indicates a very weird race condition bug.

This also means that from the bbq search, there were indeed 3 hits. But now at the script query search there are only 2?!

@benwtrent
Copy link
Member

I think we are just missing a refresh call after force merge. That might be enough.

@benwtrent
Copy link
Member

@tvernum You might be interested in this test failure. Its weird that the script query didn't "see" all the docs.

I am adding a refresh here to just double check everything. But if this fails a bunch of times again but only with the CoreWithMultipleProjectsClientYamlTestSuiteIT runner, y'all might have an interesting bug ;)

@tvernum
Copy link
Contributor

tvernum commented Mar 21, 2025

From memory, the MP tests run with 2 nodes, while the standard YAML executor has a single node. Is it possible that node count would make a difference?

@benwtrent
Copy link
Member

Is it possible that node count would make a difference?

I really shouldn't both queries are hitting the same index and are attempting to match all docs. Its really strange that the first query sees 3 docs, but then the next query only sees 2. Both of them are "match_all".

I am doing a "refresh" now and maybe this will help.

Also, CCS, CCR tests all will end up using more nodes as well and split the index as well.

@benwtrent benwtrent added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Mar 25, 2025
@benwtrent
Copy link
Member

Gonna go ahead and close: #125255

If this fails a bunch again, the robot will let us know quickly ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-risk An open issue or test failure that is a low risk to future releases :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

4 participants