Skip to content

Document breaking changes introduced with #13752 #14191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javanna opened this issue Oct 19, 2015 · 3 comments
Closed

Document breaking changes introduced with #13752 #14191

javanna opened this issue Oct 19, 2015 · 3 comments
Assignees
@colings86
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v5.0.0-alpha1

Comments

@javanna
Copy link
Member

javanna commented Oct 19, 2015

With #13752 we introduced quite some breaking changes to the java api. We should review what we did and properly document those breaking changes in the migration guide for 3.0. Also, we should consider deprecating in 2.x some the methods that we have removed from SearchRequest and SearchRequestBuilder etc.
@javanna
Copy link
Member Author

javanna commented Oct 31, 2015

Also #14384 and #14270 made the same changes to ExplainRequest, ExplainRequestBuilder, ValidateQuery and ValidateQueryRequestBuilder. These should be documented the same way as we do it for the search request.

@clintongormley
Copy link
Contributor

@javanna / @colings86 has this been done yet?

@colings86
Copy link
Contributor

Not yet no. There are still some small changes being made to the search request so I was waiting for it to settle more.

@colings86 colings86 mentioned this issue Mar 22, 2016
Merged
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Search Refactoring labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colings86 colings86

Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v5.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @colings86 @javanna