added breaking changes for the Java API to the breaking changes doc for 5.0 #17243
Conversation
colings86
added
>docs
| ==== SearchSourceBuilder | ||
|
|
||
| All methods which take an `XContentBuilder`, `BytesReference` `Map<String, Object>` or `bytes[]` have been removed in favor of providing the | ||
| relevant builder object for that feature. This means that all search requests can now be validated at call time which results in much clearer |
There was a problem hiding this comment.
can you add an example of what we mean by builder object? Also do we still want to remove the builder suffix? In that case we may want to start here by using a different name?
|
left a small comment, thanks a lot for doing this Colin |
|
One more thing, do you mind adding the same things for validate query and explain? |
|
@javanna I pushed a commit to address your comments |
| @@ -229,16 +229,16 @@ The `field` setter has been deleted. Instead the field name needs to be specifie | |||
| ==== SearchSourceBuilder | |||
|
|
|||
| All methods which take an `XContentBuilder`, `BytesReference` `Map<String, Object>` or `bytes[]` have been removed in favor of providing the | |||
| relevant builder object for that feature. This means that all search requests can now be validated at call time which results in much clearer | |||
| errors. | |||
| relevant builder object for that feature (e.g. HighlightBuilder, AggregationBuilder, SuggesterBuilder) . This means that all search requests | |||
There was a problem hiding this comment.
is it SuggesterBuilder or SuggestBuilder?
|
left very small comments, really nitpicks, LGTM though no need for another review |
|
Do we want to go and deprecate these methods in the last 2.x release? That would probably be nice to java api users, as their code will not compile anymore against 5.0. |
…anges added breaking changes for the Java API to the breaking changes doc for 5.0
Closes #14191