Skip to content

Refuse to load fields from _source when using the fields option #14489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpountz opened this issue Nov 3, 2015 · 2 comments
Closed

Refuse to load fields from _source when using the fields option #14489

jpountz opened this issue Nov 3, 2015 · 2 comments
Labels
>breaking good first issue low hanging fruit help wanted adoptme :Search/Search Search-related issues that do not fall into other categories

Comments

@jpountz
Copy link
Contributor

jpountz commented Nov 3, 2015

Spin-off from #14474. The fields option is intended to load stored fields. However it will try to load these fields from the source if they are not stored. This causes confusion because then eg. wildcards don't work.

We should deprecate the ability to load fields from _source and remove it in 3.0.

@bleskes
Copy link
Contributor

bleskes commented Nov 3, 2015

+1

On 3 nov. 2015 6:06 PM +0000, Adrien [email protected], wrote:

Spin-off from#14474(#14474). Thefieldsoption is intended to load stored fields. However it will try to load these fields from the source if they are not stored. This causes confusion because then eg. wildcards don't work.

We should deprecate the ability to load fields from _source and remove it in 3.0.


Reply to this email directly orview it on GitHub(#14489).

@nik9000
Copy link
Member

nik9000 commented Nov 3, 2015

We should deprecate the ability to load fields from _source and remove it in 3.0.

It was a great backwards compatibility step when going from 0.90.x to 1.x but I agree, it can go in 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking good first issue low hanging fruit help wanted adoptme :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Development

No branches or pull requests

4 participants